1709390 - VoiceOver Crash in [@ objc_msgSend | -[NSAccessibilityAttributeAccessorInfo _getAttributeValueForObject:]]

Status: VERIFIED FIXED

(Firefox :: Disability Access, defect, P1)

Description

[Daniel Veditz [:dveditz]]

I've his this crash twice now, and all the crashes with this signature in socorro are from today's build. Once I was trying to enter emoji into a tweet (plausibly accessibility related?) and the second crash I was in another app entirely and Firefox went down on its own. I've also experienced whole-app flickers in this build, but that might be an unrelated web render issue.

From Socorro:

Maybe Fission related. (DOMFissionEnabled=1)

Crash report: https://crash-stats.mozilla.org/report/index/ed019f47-3749-4d5f-aaa5-96e4e0210504

Reason: EXC_BAD_ACCESS / EXC_I386_GPFLT

Top 10 frames of crashing thread:

0 libobjc.A.dylib objc_msgSend 
1 AppKit -[NSAccessibilityAttributeAccessorInfo _getAttributeValueForObject:] 
2 AppKit -[NSAccessibilityAttributeAccessorInfo getAttributeValue:forObject:] 
3 AppKit ___NSAccessibilityEntryPointValueForAttribute_block_invoke.811 
4 AppKit NSAccessibilityPerformEntryPointObject 
5 AppKit _NSAccessibilityEntryPointValueForAttribute 
6 AppKit -[NSObject _accessibilityValueForAttribute:clientError:] 
7 AppKit CopyAppKitUIElementAttributeValueNoCatch 
8 AppKit CopyAttributeValue 
9 HIServices _AXXMIGCopyAttributeValue 

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Morgan, could this be from bug 1706910?

Comment 2

[Daniel Veditz [:dveditz]]

The only accessibility change I see yesterday is Part 25 of bug 1694865, but that's all in the /windows/ subdirectory
[update: completely missed bug 1706910 -- thanks Sebastian, that seems more plausible]

Comment 3

[Morgan Reschenberg [:morgan]]

Hmm possibly related to the first, I don' think its part of the windows changes. Adding eitan to CC so he can investigate too

Comment 4

[Morgan Reschenberg [:morgan]]

I can repro -- this is my crash log https://crash-stats.mozilla.org/report/index/b36a348f-4901-4b8a-8048-9ea170210504

Comment 5

[Morgan Reschenberg [:morgan]]

marking p1s1 because this causes firefox to crash on startup with VoiceOver enabled :(

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Fixed by backout of bug 1706910.

Comment 7

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Reproduced the crash on Firefox 90.0a1 (2021-05-04) under macOS 10.15.7.

The crash is no longer occurring on Firefox 90.0b4 and Firefox 91.0a1 (2021-06-07) on the same machine.