Closed Bug 1709408 Opened 4 years ago Closed 4 years ago

Crash in [@ @0x0 | libGLESv2_POWERVR_ROGUE.so@0x19dcc] x86 Asus devices

Categories

(Core :: Graphics: WebRender, defect)

x86
Android
defect

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox88 --- unaffected
firefox89 --- fixed
firefox90 --- verified

People

(Reporter: kbrosnan, Assigned: jnicol)

References

(Blocks 1 open bug)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

Crash report: https://crash-stats.mozilla.org/report/index/faa6688d-2f67-45e2-a176-4c6a40210504

Reason: SIGSEGV /SEGV_MAPERR

Top 10 frames of crashing thread:

0  @0x0 
1 libGLESv2_POWERVR_ROGUE.so libGLESv2_POWERVR_ROGUE.so@0x19dcc 
2 libGLESv2_POWERVR_ROGUE.so libGLESv2_POWERVR_ROGUE.so@0x1bd81 
3 libxul.so <gleam::gl::GlesFns as gleam::gl::Gl>::draw_arrays third_party/rust/gleam/src/gles_fns.rs:1171
4 libxul.so webrender::renderer::gpu_cache::<impl webrender::renderer::Renderer>::update_gpu_cache gfx/wr/webrender/src/renderer/gpu_cache.rs:471
5 libxul.so webrender::renderer::Renderer::render_impl gfx/wr/webrender/src/renderer/mod.rs:2148
6 libxul.so wr_renderer_render gfx/webrender_bindings/src/bindings.rs:636
7 libxul.so mozilla::wr::RendererOGL::UpdateAndRender gfx/webrender_bindings/RendererOGL.cpp:186
8 libxul.so mozilla::wr::RenderThread::UpdateAndRender gfx/webrender_bindings/RenderThread.cpp:486
9 libxul.so mozilla::wr::RenderThread::HandleFrameOneDoc gfx/webrender_bindings/RenderThread.cpp:341
Blocks: wr-android
Severity: -- → S3
Component: Graphics → Graphics: WebRender
Flags: needinfo?(jnicol)

All crashes occur during draw call for gpu cache update. Perhaps the device doesn't really support EXT_color_buffer_float despite claiming to. (I don't have such a device, but we do assert that the extension is available.)

Will switch to using texture uploads instead of draw calls for gpu cache updates on this device.

Flags: needinfo?(jnicol)

We are seeing lots of crashes on various x86 PowerVR Rogue G6430
devices during the draw calls for GPU cache updates. The crash appears
to only affect x86 devices with this specific GPU. It seems likely
that EXT_color_buffer_float is buggy, so disable usage of it on such
devices. The GPU cache will fall back to using texture uploads instead
of scatter shader updates.

Assignee: nobody → jnicol
Status: NEW → ASSIGNED
Pushed by jnicol@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6c32da995ae2 Avoid using GL_EXT_color_buffer_float on some PowerVR devices. r=kvark
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Should we uplift this to 89 beta or can it ride the trains? Thanks

Flags: needinfo?(jnicol)

Yes we should. I was planning on waiting a few days just to confirm it's fixed in nightly, as it's slightly speculative. But if you need the request sooner I'd be happy to do it now.

Flags: needinfo?(jnicol)

Ideally, I'd like to have it uplifted early next week for beta 11

Okay let's just do it now

Comment on attachment 9220366 [details]
Bug 1709408 - Avoid using GL_EXT_color_buffer_float on some PowerVR devices. r?kvark

Beta/Release Uplift Approval Request

  • User impact if declined: Browser crashes for users with affected devices
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Avoids crashing code path by using alternative method. Alternative method is simpler and currently in use on other platforms.
  • String changes made/needed:
Attachment #9220366 - Flags: approval-mozilla-beta?

Comment on attachment 9220366 [details]
Bug 1709408 - Avoid using GL_EXT_color_buffer_float on some PowerVR devices. r?kvark

Fenix speculative crash fix for specific devices, uplifting to beta so as that we can see rapidly if that fix has an effect in our crash rate, thanks.

Attachment #9220366 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified as fixed on the latest Nightly build 90.0a1 with Nokia 2.4 (Android 10) with PowerVR.
Please note that this is the only device with PowerVR we own.
I was not able to reproduce the crash.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: