1709439 - XULPopupElement.activateItem native and non-native codepaths are inconsistent with how they allow descendants.

Status: RESOLVED FIXED

(Core :: XUL, enhancement)

Description

[Neil Deakin]

The native OSX implementation of activateItem seems to allow any descendant to be supplied as the item:

parentMenu.activateItem(anyDescendantItem)

The non-native implementation however only allows direct children of 'parentMenu' to be supplied and throws an error otherwise.

mstange, I can fix this inconsistency, but which behaviour is intended here?

Comment 1

[Markus Stange [:mstange]]

I don't have a strong opinion on which behavior is preferable. The discrepancy is probably because I was unsure myself. Which behavior would you prefer?

Comment 2

[Neil Deakin]

Attachment: Bug 1709439, activateItem should allow any descendant of an open submenu to be used, r=mstange

This patch also fixes an issue where hidden native items could be activated, and makes the
error message consistent between both implementations in this case.

Comment 3

[Neil Deakin]

It looks like this is easier to allow all descendants for the native case, so I just implemented it that way.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98b251a30b42
activateItem should allow any descendant of an open submenu to be used, r=mstange,emilio

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/98b251a30b42