1709443 - Show what unknown language / region is in linktoolbar

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, enhancement)

Description

[Ian Neal]

Following on from Bug 134436 would probably be good to display something other than ??? when we encounter an unknown / unrecognised language and/or region.

Comment 1

[Ian Neal]

Attachment: 1709443-unknownlanguage-2538.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: one addition

The test case from bug 134436 can be used here to show the new wording.

Comment 2

[Job Bautista]

Comment on attachment 9220192 [details] [diff] [review]
1709443-unknownlanguage-2538.patch

Review of attachment 9220192 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Link Toolbar shows links that have unrecognized hreflangs in the testcase of bug 134436 as "Unknown (this.hreflang)".

Comment 3

[Job Bautista]

Attachment: 1709443-patch-screenshot.png

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9220192 [details] [diff] [review]
1709443-unknownlanguage-2538.patch

LGTM

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/07c6c504cb07
Show what unknown language / region is in linktoolbar. r=frg

Comment 6

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/226a59ae3e41bebd46a57ed17ad265155c7371f2
Show what unknown language / region is in linktoolbar. r=frg a=frg