Closed
Bug 1709467
Opened 3 years ago
Closed 3 years ago
Add getBuildConfiguration() info if CPU was simulated
Categories
(Core :: JavaScript: WebAssembly, enhancement, P1)
Tracking
()
RESOLVED
FIXED
90 Branch
Tracking | Status | |
---|---|---|
firefox90 | --- | fixed |
People
(Reporter: yury, Assigned: yury)
References
Details
Attachments
(1 file)
The following tests are executed regardless if CPU was replaced by a simulated one:
wasm/simd/binop-x64-ion-codegen.js
wasm/simd/binop-x86-ion-codegen.js
wasm/simd/bitselect-x64-ion-codegen.js
wasm/simd/cmp-x64-ion-codegen.js
wasm/simd/const-x64-ion-codegen.js
wasm/simd/cvt-x64-ion-codegen.js
wasm/simd/ion-bug1688713.js
wasm/simd/neg-abs-not-x64-ion-codegen.js
wasm/simd/shift-x64-ion-codegen.js
wasm/simd/shuffle-x86-ion-codegen.js
wasm/simd/splat-x64-ion-codegen.js
Currently we are adding Ion support to ARM64 and these tests shall not be run (e.g. on try) if a simulator is set.
Replacing "x64" to e.g. "x64-real" will address the issue, e.g.
// |jit-test| skip-if: !wasmSimdEnabled() || !hasDisassembler() || wasmCompileMode() != "ion" || !getBuildConfiguration()["x64-real"]; include:codegen-x64-test.js
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Severity: -- → N/A
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by ydelendik@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/49b7edf58d4a Add getBuildConfiguration() info about if CPU was simulated. r=lth
Comment 3•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•