1709472 - Change the tab icon for net error pages from warning icon to info icon

Status: VERIFIED FIXED

(Firefox :: Site Identity, enhancement, P2)

Description

[Emma Malysz]

In Bug 1575080, we changed the icon in the site identity panel/urlbar to info.svg (https://searchfox.org/mozilla-central/rev/2f109387cc6886859d3f985ed9aca352fff653b8/browser/themes/shared/controlcenter/panel.inc.css#471). The tab icon uses warning.svg.

UX requested we change this to info.svg

Comment 1

[Emma Malysz]

Attachment: Screen Shot 2021-05-04 at 2.41.32 PM.png

Comment 3

[Mike Conley (:mconley) (:⚙️) (PTO Aug 24-28)]

Attachment: Bug 1709472 - Change error page favicon from warning.svg to info.svg. r?jaws!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/289f6a96b9e4
Change error page favicon from warning.svg to info.svg. r=jaws

Comment 5

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 289f6a96b9e4 (Bug 1709472) for xpcshell failures in test_bookmarks_html.js.
https://hg.mozilla.org/integration/autoland/rev/b1fe781c2f8c009f2725924cf784179dea2a4cdc

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=289f6a96b9e4dd79b38b3e754bf926fb82710413&selectedTaskRun=SlL8FCeETFG-Lz2I8JEuPQ.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=339638912&repo=autoland&lineNumber=2454

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57f6d6639473
Change error page favicon from warning.svg to info.svg. r=jaws

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/57f6d6639473

Comment 8

[Romain Testard [:RT]]

Can we please uplift to Beta 89?

Comment 9

[Mike Conley (:mconley) (:⚙️) (PTO Aug 24-28)]

Comment on attachment 9220900 [details]
Bug 1709472 - Change error page favicon from warning.svg to info.svg. r?jaws!

Beta/Release Uplift Approval Request

• User impact if declined: Users will see a warning icon (triangle with !) rather than an info icon (circle with an i) for things like network error pages, about:sessionrestore, and about:restartrequired.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is swapping in a new asset URL for the pre-existing icon in the icons folder, which is not a risky operation.
• String changes made/needed: None.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9220900 [details]
Bug 1709472 - Change error page favicon from warning.svg to info.svg. r?jaws!

Approved for 89.0b14.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/68a1520f19f8

Comment 12

[Hani Yacoub, Desktop QA]

Verified as fixed on Windows 10 x64, macOS 10.15, Ubuntu 20.04 and on Windows 7 x64.