1709492 - CardDAV OAuth2 token expires and is not refreshed

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Geoff Lankow (:darktrojan)]

Google's OAuth tokens expire after an hour. Every synchronisation after that we get an authorisation error.

Comment 1

[Geoff Lankow (:darktrojan)]

Here we call oauth.connect with the refresh argument false.

connect just calls aSuccess() immediately because there is a token (though it's expired) and we didn't ask for it to be refreshed. I think we should check the expiry here and skip to the next block which refreshes the token. I also notice there's several branches of connect which don't call either success or failure callback. That seems dodgy. Scratch that, I overlooked something.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1709492 - Automatically refresh expired OAuth2 tokens when they are next used. r?mkmelin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/86b7fd0621bc
Automatically refresh expired OAuth2 tokens when they are next used. r=mkmelin

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9220240 [details]
Bug 1709492 - Automatically refresh expired OAuth2 tokens when they are next used. r?mkmelin

[Approval Request Comment]
Regression caused by (bug #): Never worked.
User impact if declined: Some CardDAV directories stop syncing after a time until Thunderbird is restarted.
Testing completed (on c-c, etc.): Just landed.
Risk to taking this patch (and alternatives if risky): Small.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9220240 [details]
Bug 1709492 - Automatically refresh expired OAuth2 tokens when they are next used. r?mkmelin

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 89.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/a1a3630655d2

Comment 7

[Magnus Melin [:mkmelin]]

Uplift to 78?

Comment 8

[Geoff Lankow (:darktrojan)]

Comment on attachment 9220240 [details]
Bug 1709492 - Automatically refresh expired OAuth2 tokens when they are next used. r?mkmelin

[Approval Request Comment]
Regression caused by (bug #): Never worked.
User impact if declined: Some CardDAV directories stop syncing after a time until Thunderbird is restarted.
Testing completed (on c-c, etc.): In b4.
Risk to taking this patch (and alternatives if risky): Small.

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9220240 [details]
Bug 1709492 - Automatically refresh expired OAuth2 tokens when they are next used. r?mkmelin

[Triage Comment]
Approved for esr78

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 78.11.0:
https://hg.mozilla.org/releases/comm-esr78/rev/1870cd4fa5ae