Closed Bug 1709496 Opened 4 years ago Closed 4 years ago

mozlint clippy misattributes errors

Categories

(Developer Infrastructure :: Source Code Analysis, defect)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
defect

Tracking

(firefox90 fixed)

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

Bug 1709496 - Attribute clippy issues to the specific file where they are.
48 bytes, text/x-phabricator-request
Details | Review

STR:

  • Install rust 1.52 beta
  • Run mach lint -l clippy gfx/webrender_bindings (on 3aa883d4b62291a481baca275fea5e1e5ab91dd4)

The reported error is attributed to gfx/webrender_bindings/src/lib.rs line 90, but the file only has 42 lines, and the actual error is in gfx/webrender_bindings/src/swgl_bindings.rs.

Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/829139a34ca1 Attribute clippy issues to the specific file where they are. r=sylvestre
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8b11be10e7da Fix clippy mozlint failure. r=glandium

https://hg.mozilla.org/mozilla-central/rev/829139a34ca1
https://hg.mozilla.org/mozilla-central/rev/8b11be10e7da

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: