Closed Bug 1709505 Opened 4 years ago Closed 4 years ago

[rust 1.52] -D dead-code bustage in third_party/rust/mio

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect

Tracking

(firefox-esr78 unaffected, firefox88 unaffected, firefox89 unaffected, firefox90 fixed)

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox88 --- unaffected
firefox89 --- unaffected
firefox90 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1709505 - Fix -D dead-code bustage in third_party/rust/mio.
48 bytes, text/x-phabricator-request
Details | Review

On *nix:

[task 2021-05-04T22:49:45.618Z] 22:49:45     INFO -  error: field is never read: `hdr`
[task 2021-05-04T22:49:45.618Z] 22:49:45     INFO -     --> third_party/rust/mio/src/sys/unix/uds.rs:190:17
[task 2021-05-04T22:49:45.618Z] 22:49:45     INFO -      |
[task 2021-05-04T22:49:45.618Z] 22:49:45     INFO -  190 |                 hdr: libc::cmsghdr,
[task 2021-05-04T22:49:45.618Z] 22:49:45     INFO -      |                 ^^^^^^^^^^^^^^^^^^
[task 2021-05-04T22:49:45.618Z] 22:49:45     INFO -      |
[task 2021-05-04T22:49:45.619Z] 22:49:45     INFO -      = note: `-D dead-code` implied by `-D warnings`

On Windows:

[task 2021-05-04T23:02:05.424Z] 23:02:05     INFO -  error: field is never read: `instant_notify`
[task 2021-05-04T23:02:05.424Z] 23:02:05     INFO -    --> third_party/rust/mio/src/sys/windows/tcp.rs:85:5
[task 2021-05-04T23:02:05.424Z] 23:02:05     INFO -     |
[task 2021-05-04T23:02:05.424Z] 23:02:05     INFO -  85 |     instant_notify: bool,
[task 2021-05-04T23:02:05.424Z] 23:02:05     INFO -     |     ^^^^^^^^^^^^^^^^^^^^
[task 2021-05-04T23:02:05.424Z] 23:02:05     INFO -     |
[task 2021-05-04T23:02:05.424Z] 23:02:05     INFO -     = note: `-D dead-code` implied by `-D warnings`

After bug 1708379, the build fails with --enable-warnings-as-errors with
rustc 1.52.

error: field is never read: `hdr`
    --> third_party/rust/mio/src/sys/unix/uds.rs:190:17
     |
 190 |                 hdr: libc::cmsghdr,
     |                 ^^^^^^^^^^^^^^^^^^
     |
     = note: `-D dead-code` implied by `-D warnings`

error: field is never read: `instant_notify`
   --> third_party/rust/mio/src/sys/windows/tcp.rs:85:5
    |
 85 |     instant_notify: bool,
    |     ^^^^^^^^^^^^^^^^^^^^
    |
    = note: `-D dead-code` implied by `-D warnings`
Summary: -D dead-code bustage in third_party/rust/mio → [rust 1.52] -D dead-code bustage in third_party/rust/mio
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/34a95edc55e9 Fix -D dead-code bustage in third_party/rust/mio. r=emilio

https://hg.mozilla.org/mozilla-central/rev/34a95edc55e9

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Set release status flags based on info from the regressing bug 1708634

status-firefox88: --- → unaffected
status-firefox89: --- → unaffected
status-firefox-esr78: --- → unaffected
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: