1709544 - variable tooltip is not displayed when hovering variable while paused in script using private fields

Status: VERIFIED FIXED

(DevTools :: Debugger, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Go to https://firefox-devtools-private-fields.glitch.me/
2. Open the debugger
3. On the page, click the Create instance and pause button, it should pauses in script.js
4. In getSecreatAndSalt, hover the creationDate variable on line 17

Expected results

The variable tooltip shows the value of creationDate

Actual results

The variable tooltip does not show up

---

An error is displayed in the terminal:

new SyntaxError("This experimental syntax requires enabling one of the following parser plugin(s): 'classPrivateProperties, classPrivateMethods' (4:9)", "resource://devtools/client/debugger/dist/parser-worker.js", 17120)

We have to update the babel configuration to add support for private fields.

Note that inline variable preview does not work either, and we should check if fixing this bug resolves the issue, and if not, file another specific bug

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1709544 - [devtools] Fix debugger preview tooltip on scripts with private fields. r=bomsy.

This patch adds 2 babel plugin so we can parse such scripts.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b40e026a5d61
[devtools] Fix debugger preview tooltip on scripts with private fields. r=bomsy.

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b40e026a5d61

Comment 4

[Ciprian Georgiu, Desktop QA]

I've reproduced this bug on macOS 10.5, using the steps from comment 0, on an affected Nightly build (2021-05-05).

The bug is verified as fixed on Beta 90.0b4, across platforms: Win 10 x64, macOS 10.15 and Ubuntu 18.04 x64.