1709577 - open.spotify.com - Flickering on mouseover

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

Attachment: Screencast from 05-05-2021 12:47:53 PM.webm

This needs a login to repro, will attach a screencast shortly. Isn't a regression on our side, at least as far as I could test.

I took a look and it seems like they're replacing the whole DOM for the component when moving the mouse around (this happens on Chrome too), but since we decode images async we can see some visible flickering.

I think they could use <img decoding="sync"> to prevent the flickering (or ideally not re-create the DOM so frequently?).

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Testcase?

Comment 2

[Emilio Cobos Álvarez [:emilio]]

https://html.spec.whatwg.org/#updating-the-image-data says to check the cache before delaying the load for loading="lazy". So I guess this is technically a Gecko bug.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1709577 - Remove CORS_* constants from imgIRequest, use CORSMode instead. r=tnikkel

These don't have the same value, and is a bit confusing.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1709577 - Check list of available images before deciding to defer a lazy load. r=edgar

As per https://html.spec.whatwg.org/#updating-the-image-data step 6.

Depends on D114352

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e2fa32642e6
Remove CORS_* constants from imgIRequest, use CORSMode instead. r=tnikkel

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9e2fa32642e6

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1709577 - Fix invalid src events for images. r=edgar

My previous patch still causes one WPT regression (invalid-src.html),
because we stopped firing error event for src="". However that test
times out because it doesn't correctly handle the invalid URI case. This
patch fixes it and cleans up the code a bit.

This fixes bug 1466138 too, and matches Chrome.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bab974107b3b
Check list of available images before deciding to defer a lazy load. r=edgar
https://hg.mozilla.org/integration/autoland/rev/0da1dba1749c
Fix invalid src events for images. r=edgar

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/28883 for changes under testing/web-platform/tests

Comment 11

[Sandor Molnar[:smolnar]]

Backed out for causing wpt failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/1dee84afd395dad15cd36aa5a90203b5f1e40045

Push with failures

Failure log example #1

Failure log example #2

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 13

[Emilio Cobos Álvarez [:emilio]]

Hmm, tests that depend on caching, fun.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb44c14b754f
Check list of available images before deciding to defer a lazy load. r=edgar
https://hg.mozilla.org/integration/autoland/rev/ceed6d7fca1c
Fix invalid src events for images. r=edgar

Comment 15

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1709577) for WPT Failures in /html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url.html. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=339071196&repo=autoland&lineNumber=9059

Backout:
https://hg.mozilla.org/integration/autoland/rev/3d547f7fc1c43f7d44ea0ffd224eb74bf4a5c99a

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b0a81bc0d5f
Check list of available images before deciding to defer a lazy load. r=edgar
https://hg.mozilla.org/integration/autoland/rev/1f46ca1c7c27
Fix invalid src events for images. r=edgar

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2730f2d2cf9d
Fix more tests to avoid depending on the image cache.

Comment 19

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5b0a81bc0d5f
https://hg.mozilla.org/mozilla-central/rev/1f46ca1c7c27
https://hg.mozilla.org/mozilla-central/rev/2730f2d2cf9d

Comment 20

[Florin Strugariu [:Bebe]]

== Change summary for alert #30039 (as of Tue, 11 May 2021 06:28:24 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
46%	imdb	ContentfulSpeedIndex	android-hw-g5-7-0-arm7-api-16-shippable-qr	warm webrender	3,526.83 -> 1,897.42
21%	imdb	SpeedIndex	android-hw-g5-7-0-arm7-api-16-shippable-qr	warm webrender	3,289.79 -> 2,584.25
21%	imdb	SpeedIndex	android-hw-g5-7-0-arm7-api-16-shippable-qr	warm webrender	3,260.33 -> 2,585.50
2%	imdb	PerceptualSpeedIndex	android-hw-g5-7-0-arm7-api-16-shippable-qr	warm webrender	4,339.75 -> 4,231.58

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=30039

Comment 21

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 22

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham