1709606 - Some cleanups for bug 1708416

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Description

[Robert Mader [:rmader]]

Cleanup some code to make bug 1708416 nicer and potentially improve stability.

Comment 1

[Robert Mader [:rmader]]

Attachment: Bug 1709606 - Move WindowSurface* into the gtk backend, r=stransky

It's only used by the GTK backend and all other users are located
there as well. Further more, it's unlikely that the will ever be
another X11 backend or that these classes will get reused elsewhere.

So in order to keep changes to WindowSurface out of the common
widget space, move it into gtk.

While on it, also clean up the affected moz.build files a bit
by making orders more consistent. No functional changes intended.

Comment 2

[Robert Mader [:rmader]]

Attachment: Bug 1709606 - Make WindowSurface refcouted, r=stransky

There doesn't seem to be an obvious reason why it should not be
and allowing to hold additional refs appears to be desirable in
situation when we have to deal with callbacks, which may arrive
after WindowSurfaceProvider::CleanupResources() was called.

Depends on D114422

Comment 3

[Robert Mader [:rmader]]

Attachment: Bug 1709606 - Move GfxInfoX11 into gtk and remove X11 from the name, r?stransky,aosmond

It is only used by the GTK backend, supports Wayland as well and
is highly unlikely to be reused by another backend.

This is also better in line with how this is handled for other
platforms.

While on it, do some small cleanups.

Depends on D114423

Comment 4

[Robert Mader [:rmader]]

Attachment: Bug 1709606 - Rename CompositorWidget::AsX11() to CompositorWidget->AsGTK(), r?stransky,#gfx-reviewers

Nowadays we often use it for Wayland, which is confusing. Also, it
has a bunch of GTK specific functions, which an alternative X11
implementation would like not have. So a explicit name is probably
deserved.

Depends on D114424

Comment 5

[Robert Mader [:rmader]]

Try run to verify things don't break: https://treeherder.mozilla.org/jobs?repo=try&revision=e07f477775dd44810720a8357966ea6896534409

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e955745b8047
Move WindowSurface* into the gtk backend, r=stransky
https://hg.mozilla.org/integration/autoland/rev/878b9d8262e3
Make WindowSurface refcouted, r=stransky
https://hg.mozilla.org/integration/autoland/rev/059be8a083a3
Move GfxInfoX11 into gtk and remove X11 from the name, r=stransky
https://hg.mozilla.org/integration/autoland/rev/1cf17b2e8f9a
Rename CompositorWidget::AsX11() to CompositorWidget->AsGTK(), r=stransky,nical

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e955745b8047
https://hg.mozilla.org/mozilla-central/rev/878b9d8262e3
https://hg.mozilla.org/mozilla-central/rev/059be8a083a3
https://hg.mozilla.org/mozilla-central/rev/1cf17b2e8f9a