1709640 - Add GeckoView lite build type

Status: RESOLVED FIXED

(GeckoView :: General, task, P1)

Description

[[ex-Mozilla] Agi Sferro | :agi]

With the upcoming addition of Glean to the GeckoView build we want to provide a version of GeckoView without any additional libraries. To do that we need to add a new build variant in our automation.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1709640 - Rename android-api-16 to android-arm.

We don't offer API splits any more, and with the separation of GeckoView with
the rest of the front-end it's increasingly unlikely that we will in the
future.

This change makes it so that the build name doesn't contain the API version so
that we can update it without breaking all the automation that relies on the
build name.

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1709640 - Add GeckoView Lite build variant.

This patch adds a new GeckoView build variant dubbed "lite". We are in the
process of adding some optional dependencies to GeckoView that are needed by
Fenix (like Glean and Nimbus) which are likely not going to be used by anyone
else at Mozilla. To avoid bloating third party consumers, we provide a
geckoview-lite build that doesn't contain any optional dependency.

The min SDK version of GeckoView (non-lite) is being increased to 21 to match
Glean's min SDK. Given that Fenix's min SDK version is already 21 and that the
lite version's min SDK is still at 16 this change is safe to do and will not
incur in any loss of usability.

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1709640 - Remove unused variables in android/confvars.sh

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Gonna land this slowly since the patches are fairly big.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/453cb34e4a4a
Rename android-api-16 to android-arm. r=marionette-reviewers,firefox-build-system-reviewers,nalexander,whimboo,aklotz,releng-reviewers,mhentges,glandium,mtabara

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing linting failures in perfdocs/config

Backout link: https://hg.mozilla.org/integration/autoland/rev/3ae9a41924cc3bd3dda598642fce8b90ac3e9d7d

Push with failures

Failure log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5eb71cf51d5
Rename android-api-16 to android-arm. r=marionette-reviewers,firefox-build-system-reviewers,nalexander,whimboo,aklotz,releng-reviewers,mhentges,glandium,mtabara

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b5eb71cf51d5

Comment 9

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1709640 - Label Android build jobs for 4.1.

Not sure how it happened (probably copy-paste?) but a lot of Android jobs are
marked for "Android 4.0" (API 14) or "Android 4.2" (API 18) while really they
are all for Android 4.1 (API 16). This patch fixes that.

Comment 10

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/7174

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/decc4edd47f9
Label Android build jobs for 4.1. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/3a6a274dae0d
Add GeckoView Lite build variant. r=jmaher,aklotz,mhentges,glandium
https://hg.mozilla.org/integration/autoland/rev/d8f2f3cc4da7
Remove unused variables in android/confvars.sh r=nalexander,aklotz

Comment 12

[Cristian Brindusan [:cbrindusan]]

Backed out 3 changesets (bug 1709640) for causing android-4-1-armv7 pgo build bustages.
https://hg.mozilla.org/integration/autoland/rev/3793e0a6acf5b43cc37cf8164047975bf08b0852

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=d8f2f3cc4da701bb80ef103a5c37ede85bc25af3&selectedTaskRun=D0qd3BJDTmaAJHNlFEIETg.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=342060908&repo=autoland&lineNumber=532

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/667e768fd75e
Add GeckoView Lite build variant. r=jmaher,aklotz,mhentges,glandium
https://hg.mozilla.org/integration/autoland/rev/7c45682a8f98
Label Android build jobs for 4.1. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/20645ae32b84
Remove unused variables in android/confvars.sh r=nalexander,aklotz

Comment 14

[Atila Butkovits]

Backed out for causing android build bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/6238e92b6f4172905e58930866ffe4970dd000fe

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=f072adb45b8546fed63ba1be43de2ca22229268b&selectedTaskRun=O1_SX-jiTACS6j_8gqbo0w.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=345485382&repo=autoland&lineNumber=25707

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45b07d37f247
Add GeckoView Lite build variant. r=jmaher,aklotz,mhentges,glandium
https://hg.mozilla.org/integration/autoland/rev/c7f2fa8d7535
Label Android build jobs for 4.1. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/abc4249b08a0
Remove unused variables in android/confvars.sh r=nalexander,aklotz

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing geckoview-junit tasks on shippable lite platform, together with bug 1718341:

https://hg.mozilla.org/integration/autoland/rev/27f30c002564d083369f5149413ad2f6c43000f0

Push with failure: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=P6uy-eKrS96zRGKeeYLKgg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=abc4249b08a090e25d3895a25ebe373a51c78bc9
Failure log: https://treeherder.mozilla.org/logviewer?job_id=345717766&repo=autoland

[task 2021-07-20T09:05:58.729Z] 09:05:58 FATAL - Can't download from https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ISFjBS8eRWavuuqDd-eeUg/artifacts/public/build/target.mochitest.tests.tar.gz
[task 2021-07-20T09:05:58.729Z] 09:05:58 FATAL - Caught exception: HTTP Error 404: Not Found

This task didn't run before except early June and was also failing back then.

Comment 17

[Alexandru Michis [:malexandru]]

Also caused these GeckoView multi-arch fat AAR & android-5-0-geckoview-fat-aar failures.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f918535301cb
Add GeckoView Lite build variant. r=jmaher,aklotz,mhentges,glandium
https://hg.mozilla.org/integration/autoland/rev/62d01bf315a4
Label Android build jobs for 4.1. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/2f8bbf2478c7
Remove unused variables in android/confvars.sh r=nalexander,aklotz

Comment 19

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Are their redundant test tasks which should return the same results for lite and non-lite builds? E.g. are there difference between the web platform features enabled (web-platform-tests) or the graphics and layout stack (reftests)? Similar for mochitest plain.

Comment 20

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f918535301cb
https://hg.mozilla.org/mozilla-central/rev/62d01bf315a4
https://hg.mozilla.org/mozilla-central/rev/2f8bbf2478c7

Comment 21

[[ex-Mozilla] Agi Sferro | :agi]

There aren't (intentional) content differences between lite and non-lite builds. I would wait until we migrate Fenix to the non-lite build before stopping running the tests though.