1709644 - Crashes in mozilla::gfx::RecordedPathCreation::PlayEvent starting in 89 during GPU process start

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

This is one of the top GPU process crashes in 89

Comment 1

[Bob Owen (:bobowen)]

Attachment: Bug 1709644: Add null checks for GetReferenceDrawTarget when called on CanvasTranslator. r=jrmuizel!

Also, return false from CreateReferenceTexture when mBaseDT is null.

Comment 2

[Bob Owen (:bobowen)]

https://treeherder.mozilla.org/jobs?repo=try&revision=153c78feac28a27135611d7452e288a19c06b1a5

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f10ba86b62c9
Add null checks for GetReferenceDrawTarget when called on CanvasTranslator. r=jrmuizel

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f10ba86b62c9

Comment 5

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

No crashes in 89, so no need for an uplift.
Disregard my previous comment, that's a GPU crash, we don't get those in crash-stats.

Comment 6

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:bobowen, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Bob Owen (:bobowen)]

Comment on attachment 9220423 [details]
Bug 1709644: Add null checks for GetReferenceDrawTarget when called on CanvasTranslator. r=jrmuizel!

Beta/Release Uplift Approval Request

• User impact if declined: This is one of the top GPU process crashes, when looking at telemetry crash pings.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple null checks.
• String changes made/needed: None

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9220423 [details]
Bug 1709644: Add null checks for GetReferenceDrawTarget when called on CanvasTranslator. r=jrmuizel!

Approved for 89.0b12.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ad6a9ad0b5ab