1709707 - Localize attribution/caption string shown on welcome page

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P2)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to submit attribution string for localization in Fx90

https://searchfox.org/mozilla-central/source/browser/components/newtab/aboutwelcome/lib/AboutWelcomeDefaults.jsm#217

Comment 1

[Ed Lee :Mardak]

We'll want to land this towards the end of 90 nightly to avoid uplift conflicts. The string in only shown to en-* users in MR1/89.

Comment 2

[Julien Chaupitre]

Hi Punam, I understand your team is using P1 as an indicator that this work is in progress, but doing so makes it sound like this issue is a launch blocker when it's not. I'm downgrading this back to P2 to avoid this false indicator.

Comment 3

[Punam Dahiya [:pdahiya]]

(In reply to Julien Chaupitre from comment #2)

Hi Punam, I understand your team is using P1 as an indicator that this work is in progress, but doing so makes it sound like this issue is a launch blocker when it's not. I'm downgrading this back to P2 to avoid this false indicator.

Good to know, will keep that in mind while updating Proton on-boarding bugs in future, thanks!

Comment 4

[Emily McMinn :emcminn]

Attachment: Bug 1709707 - Localize image caption & update test

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b10ba921619
Localize image caption & update test r=Mardak,fluent-reviewers,flod

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a727ff076e3
Fixed file-whitespace failure in onboarding.ftl. a=lint-fix CLOSED TREE

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8b10ba921619
https://hg.mozilla.org/mozilla-central/rev/6a727ff076e3

Comment 8

[Francesco Lodolo [:flod]]

@Emily
Asking you as the patch owener, hopefully you can redirect to the right person.

For some languages, you need to know the gender of the person to translate nouns like "designer" and "fan". What should be used here? The assumption would be she/her, but I wanted to double check.

Comment 9

[Emily McMinn :emcminn]

Hi @flod, thanks for checking! Yep, I've confirmed that she/her are the right pronouns for Soraya. :) Would you like me to update the translation note in the fluent file to make note?

Comment 10

[Francesco Lodolo [:flod]]

(In reply to Emily McMinn :emcminn from comment #9)

Hi @flod, thanks for checking! Yep, I've confirmed that she/her are the right pronouns for Soraya. :) Would you like me to update the translation note in the fluent file to make note?

Thanks, that would be great. In the meantime, I can add a note in Pontoon, so it's not urgent.

Comment 11

[Ed Lee :Mardak]

This string is hardcoded and hidden from non-en-* in 89. We'll show the localized one for 90+

Comment 12

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm that the image caption is successfully displayed on the "about:welcome" page.

Verified using the latest Firefox Beta (90.0b1 Build ID - 20210601190019, DE, RO, and AR locales) installed on Windows 10 x64, macOS 10.15.7, and Linux Mint 20 x64.