1709724 - [wpt-sync] Sync PR 28852 - [GridNG] Fix invalidation logic for out of flow items via simplified layout

Status: RESOLVED FIXED

(Core :: Layout: Grid, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 28852 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28852
Details from upstream follow.

b'Ana SollanoKim <[e-mail]>' wrote:

[GridNG] Fix invalidation logic for out of flow items via simplified layout

This CL addresses a failure where an absolutely positioned item changed
its position dynamically. Previously, a new |containing_block_rect| was
not being added nor re-computed in |SimplifiedLayoutAlgorithm| for
out of flow items that are children of the grid, thus their position was
incorrect. This change computes the new containing block by calling
existing helpers in |NGGridLayoutAlgorithm|. As a result, some methods
had to be changed and constructors overloaded in order to use what was
already computed and stored in |NGGridData|.

Bug: 1045599
Change-Id: Ic299a57aa5e69063c6f8d0f39c92772503b15f30

Reviewed-on: https://chromium-review.googlesource.com/2872591
WPT-Export-Revision: eb9d33e900c5df40e2beac99d346265d66f1ec21

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d81da1da772b627f8adb8f6c78be5d9506f42fbe

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60adfa32d328
[wpt PR 28852] - [GridNG] Fix invalidation logic for out of flow items via simplified layout, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c769c37c3bd
[wpt PR 28852] - [GridNG] Fix invalidation logic for out of flow items via simplified layout, a=testonly

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/601136e9b504
[wpt PR 28852] - [GridNG] Fix invalidation logic for out of flow items via simplified layout, a=testonly

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/601136e9b504