Open Bug 1709880 Opened 3 years ago Updated 10 months ago

Switch mozilla::intl to use mozilla::Span rather than std::string_view

Categories

(Core :: Internationalization, task, P4)

task

Tracking

()

People

(Reporter: gregtatum, Unassigned)

References

Details

(Whiteboard: [i18n-unification])

From the review of Bug 1705156

dminor: question: I've had a quick look at the SpiderMonkey code, and they seem to be using mozilla::Span quite a bit in the DateTimeFormat code. Should we consider using mozilla::Span in our APIs? I'd rather switch over now than after we've written a bunch more code.

gregtatum: Yeah I think in general I would prefer to use the mozilla::Span, as it maps more closely into my mind of "this is data". Since SpiderMonkey is using it as well I'd be happy to align on that. I would prefer to follow-up either with another commit or a follow-up patch to do so.

dminor: I think we should do this in a follow bug once this lands and my NumberFormat work lands.

Whiteboard: [i18n-unification]
Assignee: gtatum → nobody

I took an initial stab at this but struggled with the string comparison of Spans, and dropped it for other work.

Assignee: nobody → enordin
Priority: P2 → P4
Assignee: enordin → nobody
You need to log in before you can comment on or make changes to this bug.