1710000 - Allow the "remote-listening" observer to also print other messages to stderr

Status: RESOLVED FIXED

(Remote Protocol :: Agent, enhancement, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Right now the Remote Agent's command line handler prints a line to stderr where the DevTools server is listening on:

eprintln!("DevTools listening on {}", url.to_string_lossy());

With the hard-coded prefix DevTools listening on it won't allow us to just also print a line for WebDriver BiDi when the protocol is enabled.

As such when notifying the remote-listening observer the complete string should be passed-in.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1710000 - [remote] Allow the "remote-listening" observer to also print other messages to stderr.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8307b8b0bc7c
[remote] Allow the "remote-listening" observer to also print other messages to stderr. r=remote-protocol-reviewers,jgraham

Comment 3

[Iulian Moraru]

Backed out for causing mochitests failures on browser_agent.js.

Push with failures

Failure log

Backout link

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

There is a test that I didn't check. :/ Accounting for the prefix will make it work.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd2903038e81
[remote] Allow the "remote-listening" observer to also print other messages to stderr. r=remote-protocol-reviewers,jgraham,jdescottes

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/bd2903038e81