Closed Bug 1710000 Opened 5 months ago Closed 4 months ago

Allow the "remote-listening" observer to also print other messages to stderr

Categories

(Remote Protocol :: Agent, enhancement, P2)

enhancement
Points:
2

Tracking

(firefox90 fixed)

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [bidi-m1-mvp])

Attachments

(1 file)

Right now the Remote Agent's command line handler prints a line to stderr where the DevTools server is listening on:

eprintln!("DevTools listening on {}", url.to_string_lossy());

With the hard-coded prefix DevTools listening on it won't allow us to just also print a line for WebDriver BiDi when the protocol is enabled.

As such when notifying the remote-listening observer the complete string should be passed-in.

Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Summary: Allow the "remote-listening" observer to also print WebDriver BiDi messages to stderr → Allow the "remote-listening" observer to also print other messages to stderr
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8307b8b0bc7c
[remote] Allow the "remote-listening" observer to also print other messages to stderr. r=remote-protocol-reviewers,jgraham

Backed out for causing mochitests failures on browser_agent.js.

Push with failures

Failure log

Backout link

Flags: needinfo?(hskupin)

There is a test that I didn't check. :/ Accounting for the prefix will make it work.

Flags: needinfo?(hskupin)
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bd2903038e81
[remote] Allow the "remote-listening" observer to also print other messages to stderr. r=remote-protocol-reviewers,jgraham,jdescottes
Points: --- → 2
Priority: -- → P2
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.