1710140 - Clean up inlined FunCall/FunApply bailout code

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P1)

Description

[Iain Ireland [:iain]]

Jan pointed out in #warpbuilder that some of the FunCall/FunApply bailout code was missing code coverage.

FunCall is missing a test for inlining foo.call() with no arguments. The FunApply code is just dead; we optimize FunApply into a direct call to the callee in some cases, but we no longer support inlining the callee. (Ion supported inlining only in the case of foo.apply({}, arguments) inside an already inlined function, where we knew the exact contents of arguments.) We can clean it up.

Comment 1

[Iain Ireland [:iain]]

Attachment: Bug 1710140: Improve test coverage of inlined bailout code r=jandem

While removing dead code I accidentally broke getters and setters, and noticed that only setters currently have coverage (ion/bug765454.js), so I'm adding a testcase for bailing out inlined getters as well.

Driveby: I've had a local patch floating around for a while to tweak trial inlining jitspew, but I've been too lazy to open a bug and land it; this is just related enough to justify folding it in.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60d0ce3bf4d4
Improve test coverage of inlined bailout code r=jandem

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/60d0ce3bf4d4