1710145 - Support CTAD with RefPtr from already_AddRefed

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Andrew McCreight (out until 2026) [:mccr8]]

This does not work: RefPtr foo = GetFoo();, where GetFoo() returns an already_AddRefed. Apparently we can add something or other so it'll work.

In a review comment in my patch for bug 1709715, kmag said "I think we need to either just remove the is_convertible_v guards in the constructors and let them just fail the conversion normally, or add deduction guides so it works with the current constructors."

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1710145 - Deduction guide RefPtr(already_AddRefed<T>) -> RefPtr<T> - r?kmag

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10151fddafaf
Deduction guide RefPtr(already_AddRefed<T>) -> RefPtr<T> - r=kmag

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/10151fddafaf