Closed
Bug 1710279
Opened 3 years ago
Closed 3 years ago
[wpt-sync] Sync PR 28916 - Enable mypy for tools/quic/
Categories
(Testing :: web-platform-tests, task, P4)
Testing
web-platform-tests
Tracking
(firefox90 fixed)
RESOLVED
FIXED
90 Branch
Tracking | Status | |
---|---|---|
firefox90 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 28916 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/28916
Details from upstream follow.
b'Philip J\xc3\xa4genstedt <philip@foolip.org>' wrote:
Enable mypy for tools/quic/
This code was already mostly annotated, but needs updating to pass our
mypy.ini rules. A few changes are noteworthy:
- QuicTransportProtocol.streams was removed rather than annotated,
because it's actually unused.- An assert for self.handler is added after process_client_indication()
to it clear that that it can't be None in the following loop.Part of https://github.com/web-platform-tests/wpt/issues/28833.
Depends on https://github.com/web-platform-tests/wpt/pull/28900.
Assignee | ||
Updated•3 years ago
|
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Assignee | ||
Updated•3 years ago
|
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Assignee | ||
Comment 1•3 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=08a295955878527bb292b3ee714d01ccececcb90
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e919a2c36dda [wpt PR 28916] - Enable mypy for tools/quic/, a=testonly
Assignee | ||
Comment 3•3 years ago
|
||
Test result changes from PR not available.
Comment 4•3 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•