Closed Bug 1710298 Opened 3 years ago Closed 3 years ago

chatZilla needs to understand mIRC color code 99

Categories

(SeaMonkey :: Chat, enhancement)

enhancement

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
seamonkey 2.88
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

()

Details

(Whiteboard: SM2.53.9)

Attachments

(1 file)

In mIRC the color code 99 is used to indicate a transparent color, see URL for more details.
Whilst here update the regexp and use padStart to make the code simpler.

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: mIRC color 99 doesn't behave as it should
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Attachment #9221008 - Flags: review?(frgrahl)
Attachment #9221008 - Flags: approval-comm-release?
Attachment #9221008 - Flags: approval-comm-esr60?
Whiteboard: SM2.53.9

Comment on attachment 9221008 [details] [diff] [review]
1710298-irc-mirc-color99-2539.patch

LGTM

Attachment #9221008 - Flags: review?(frgrahl)
Attachment #9221008 - Flags: review+
Attachment #9221008 - Flags: approval-comm-release?
Attachment #9221008 - Flags: approval-comm-release+
Attachment #9221008 - Flags: approval-comm-esr60?
Attachment #9221008 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/c77b80c6451e
chatZilla needs to understand mIRC color code 99. r=frg

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey 2.88
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: