1710344 - [Linux, Wayland, Snap] Unable to move bookmarks in menus

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[fthx]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

Try to move a bookmark item in any bookmarks menu.

No issue while running X11.

Actual results:

Nothing.

Expected results:

Move it.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[fthx]

Forgot to mention I can remove a bookmark, so that's not RW rights related.

Comment 3

[Simona Badau, Desktop QA]

I can confirm this issue - reproduced it on the latest Firefox Snap 95 beta 4 with Wayland and also on the latest Nightly 96.0a1, Firefox 95 beta 4, Firefox 94.0.1, and Firefox 91.3.0 (wayland Window Protocol).

Setting this to NEW.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

We're not getting drag_move from the popup window here.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

This is caused by different D&D coordinates reported from X11 and Wayland. Gtk issue https://gitlab.gnome.org/GNOME/gtk/-/issues/4437

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1710344 [Wayland] Make D&D work with popups, r?emilio

Right now D&D on popups are not possible due to https://gitlab.gnome.org/GNOME/gtk/-/issues/4437 and wrong event handling.
To fix that we do in this patch:

• Listen for D&D events on mShell instead of on mContainer as we're getting D&D events there.
• Compensate https://gitlab.gnome.org/GNOME/gtk/-/issues/4437 and add window position to D&D coordinates reported by D&D handlers.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c0203ff5e9b
[Wayland] Make D&D work with popups, r=emilio

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/9c0203ff5e9b

Comment 10

[[e-mail]]

wontfix is not a solution!

Comment 11

[Darkspirit]

(In reply to [e-mail] from comment #10)

wontfix is not a solution!

Fixed 96 (currently Beta) will become Stable on 2022-01-11.

Comment 12

[[e-mail]]

Still same problem with FF 98.0.1

Comment 13

[[e-mail]]

Still same problem on Ubuntu 22.04 Wayland session with:
corrado@corrado-p5-jj-0203:$ firefox-trunk --version
Mozilla Firefox 100.0a1
corrado@corrado-p5-jj-0203:$
Problem does not occur with same FF in X11 session

Comment 14

[Gre0]

Since a few weeks I use Ubuntu 22.04 (Wayland), and I can't move (Drag&Drop) tabs in Firefox (Snap now on 98.0.2).
Moving tabs to the bookmarks to save them does not work either.

Comment 15

[andreas.rabus]

+1
same problem here, drag&drop with JS isn't working and rearranging tabs in the tab bar is not working, too.

Comment 16

[andreas.rabus]

(In reply to andreas.rabus from comment #15)

+1
same problem here, drag&drop with JS isn't working and rearranging tabs in the tab bar is not working, too.

Oh, firefox snap 98.0.2-1 1154 on Ubuntu 22.04 Beta using Wayland under Gnome.

Comment 17

[Martin Stránský [:stransky] (ni? me)]

Thanks for the report folks. Please test latest nightly on Ubuntu 22.04/Wayland:
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems#Testing_Mozilla_binaries

If you can reproduce it please open a new bug for it and post BZ number here.
Thanks!

Comment 18

[fthx]

I tried with latest snap 100.0b1 from beta channel.
Same issue exists.

Comment 19

[fthx]

Cannot move tabs too, that's the same bug I guess.

Comment 20

[Martin Stránský [:stransky] (ni? me)]

Yes, I can reproduce that too. Strange enough it works in Fedora 35. I wonder if that's some Ubuntu specific bug or so.
Please file a new bug for it and post bug ID here.
thanks.

Comment 21

[fthx]

https://bugzilla.mozilla.org/show_bug.cgi?id=1763090

Comment 22

[[e-mail]]

On Ubuntu 22.04 Wayland session:
corrado@corrado-p5-jj-0203:$ inxi -SGx
System:
Host: corrado-p5-jj-0203 Kernel: 5.15.0-23-generic x86_64 bits: 64
compiler: gcc v: 11.2.0 Desktop: GNOME 42.0
Distro: Ubuntu 22.04 (Jammy Jellyfish)
Graphics:
Device-1: Intel 4th Generation Core Processor Family Integrated Graphics
vendor: Gigabyte driver: i915 v: kernel bus-ID: 00:02.0
Display: wayland server: X.Org v: 1.22.1.1 with: Xwayland v: 22.1.1
compositor: gnome-shell driver: X: loaded: modesetting unloaded: fbdev,vesa
gpu: i915 resolution: 1680x105060Hz
OpenGL: renderer: Mesa Intel HD Graphics 4400 (HSW GT2)
v: 4.6 Mesa 22.0.1 direct render: Yes
corrado@corrado-p5-jj-0203:~$

same problem with FF snap 98.0.2-1 1154
also with FF snap 100.0a1 1201

no problem with
corrado@corrado-p5-jj-0203:$ apt policy firefox-trunk
firefox-trunk:
Installed: 100.0a1hg20220404r613239-0ubuntu0.22.04.1umd1
Candidate: 100.0a1hg20220404r613239-0ubuntu0.22.04.1umd1
Version table:
*** 100.0a1hg20220404r613239-0ubuntu0.22.04.1umd1 500
500 https://ppa.launchpadcontent.net/ubuntu-mozilla-daily/ppa/ubuntu jammy/main amd64 Packages
100 /var/lib/dpkg/status
corrado@corrado-p5-jj-0203:~$

Comment 23

[[e-mail]]

Seems ok with firefox 99.0.1-1

Comment 24

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue using an affected nightly build from 2021-05-09 with Wayland, on Ubuntu 22.04.
Verified as fixed on Firefox 96.0.3 (20220126154723) and latest Firefox snap 104.0.