1710462 - Window-modal dialogs like the "close tabs" warning do not grow when they start too small and the window grows

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect, P2)

Description

[:Gijs (he/him)]

When the window is short and a modal doesn't fit, the natural user reaction is to make the window taller. It's unfortunate that right now, we then do not grow the dialog, leaving it cut-off. I think we can do better.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1710462 - allow SubDialogs dialogs to grow if the document's inner scroll height is initially larger than the window's, r?Mardak

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/160daad53292
allow SubDialogs dialogs to grow if the document's inner scroll height is initially larger than the window's, r=Mardak

Comment 3

[Iulian Moraru]

Backed out for causing browser chrome failures on browser_subdialogs.js.

Push with failures

Failure log

Backout link

Comment 4

[:Gijs (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=64d60b98387804762cc832daf6e30b6c62e829fd

Comment 5

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Attachment: Screen Shot 2021-05-13 at 11.23.53.png

Also happens if following these steps when signing out of FX account.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae4fbca18728
allow SubDialogs dialogs to grow if the document's inner scroll height is initially larger than the window's, r=Mardak,preferences-reviewers,jaws

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/ae4fbca18728

Comment 8

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Verified in latest nightly build 90.0a1 (2021-05-18) (64-bit), using win 10 pro, ubuntu 20.04, and mac0s 11.4 beta, the issue no longer reproduces. When resizing the buttons are shown properly.
Updating flag and status accordingly.
Best regards,
Clara