1710560 - [macOS] Making the browser smaller while Close and tab window is displayed shows the browser window controls over the window

Status: NEW

(Toolkit :: Content Prompts, defect, P2)

Description

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: Screenshot 2021-05-11 at 09.41.43.png

Affected versions

• 90.0a1 (20210510160229)

Affected platforms

• macOS 11.3.1
• macOS 10.15

Steps to reproduce

1. Open Firefox and a few tabs.
2. Resize the browser making it smaller.
3. Click the Close browser button.

Expected result

• The Browser controls are displayed under the modal.

Actual result

• The browser controls are displayed over the modal window.

Regression range

• This is reproducible after bug 1699430 landed. Maybe it was before that as well but the close window was not positioned in the same place.

Notes

• Attached a screenshot.

Comment 1

[Marco Castelluccio [:marco]]

Gijs, can you take a look?

Comment 2

[:Gijs (he/him)]

Product assigned this a p2b so it's not a priority right now. I think even that is kind of high, IMO - a window both this narrow and this short (if it's taller, there'll be no overlap) is kind of useless anyway, to then get a dialog like this in it is rare, and both the warning and the caption buttons remain usable in the current state, even if it looks a bit crummy. We can't easily overlay the dialog on top of the caption buttons because of how macOS caption buttons are implemented, AFAIK.

If someone else wants to fix this, I'm guessing we'd want to assign a higher minimum width to the window if the main toolbars are visible (ie taking account of the chromehidden attribute to avoid restricting the size of popup windows) - it'd need to be the width of the modal dialogs + 2 x the caption button width. Though then I'm sure people will also be upset about not being able to make their window narrower than that, if it's a significant increase from the current minimum width (which I'm not sure about).