Open Bug 1710575 Opened 4 years ago Updated 2 years ago

profiler_add_network_marker should accept a count with type uint64_t

Categories

(Core :: Gecko Profiler, task, P3)

Product:
Core
Component:
Gecko Profiler
Type:
task

Tracking

()

People

(Reporter: julienw, Unassigned, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxp])

clang-tidy starts complaining about that (and it's totally right).
Indeed we always pass an uint64_t, but the function accepts int64_t.

=> https://searchfox.org/mozilla-central/rev/cca1566127a2fcc013e9c09f9d90ed70df2250a4/tools/profiler/core/platform.cpp#5690

That sounds reasonable.
Note that we'll need to convert it to int64_t before giving it to aWriter.IntProperty().

Priority: -- → P3
Mentor: canaltinova
You need to log in before you can comment on or make changes to this bug.