1710645 - Re-add the 'threads' spec-tests

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect, P3)

Description

[Ryan Hunt [:rhunt] (PTO Sept 7-11)]

Fix failing 'threads' spec-tests and start importing them [1].

[1] https://searchfox.org/mozilla-central/rev/cca1566127a2fcc013e9c09f9d90ed70df2250a4/js/src/jit-test/etc/wasm/generate-spectests/config.toml#40

Comment 1

[Ryan Hunt [:rhunt] (PTO Sept 7-11)]

We accidentally removed these tests in bug 1967790. We should add them back.

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1967790

:bvisness, since you are the author of the regressor, bug 1967790, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Ben Visness [:bvisness]]

We actually removed them in bug 1873776, it seems. (See commit.) It's not clear to me why we did this.

Comment 4

[Ben Visness [:bvisness]]

Attachment: Bug 1710645: Add threads proposal spec tests. r=rhunt

The key changes in this patch are:

• Adding thread support to the converter and test harness
• Adding the threads proposal to the config

Most of the changes in this patch are noise due to a change in how we
escape JS for template strings. (A double dollar sign does not escape
anything; presumably this was a mistake.)

Comment 5

[Ben Visness [:bvisness]]

Attachment: Bug 1710645: Fix atomics test with incorrect semantics. r=rhunt

The atomics.wast spec test contains some tests that disagree with the
overview semantics for cmpxchg, and which disagree with the typical
behavior of such an instruction. These tests have been modified to
assert the correct values.

Comment 6

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1967790

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4d0f868cf4ae
https://hg.mozilla.org/integration/autoland/rev/861f0764c68d
Add threads proposal spec tests. r=rhunt

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/861f0764c68d

Comment 9

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:bvisness, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox141 to wontfix.

For more information, please visit BugBot documentation.