1710664 - FOG should report Update Channel, not Build Channel

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P1)

Description

[Chris H-C :chutten]

"Build Channel" is a phrase which here means "The channel reported by the binary" which for Release Candidate builds is "release".

"Update Channel" is a phrase which here means "The channel the profile asks for updates from" which for Release Candidate builds is "beta".

Presently, FOG reports "Build Channel" in client_info.app_channel and Firefox Telemetry reports "Update Channel" in application.channel.

This bug is for changing FOG to report the "Update Channel" instead. Telemetry uses UpdateUtils to get the channel. FOG can't reach that and will have to build its own logic. Also of interest might be the code that determines if Telemetry is on prerelease (which also has to deal with RC builds).

Comment 1

[Chris H-C :chutten]

Attachment: Bug 1710664 - Factor FOG's upload pref observer to its own mod r?janerik!

Comment 2

[Chris H-C :chutten]

Attachment: Bug 1710664 - FOG should report the Update Channel not Build Channel r?janerik!

Depends on D114981

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97df27492322
Factor FOG's upload pref observer to its own mod r=janerik
https://hg.mozilla.org/integration/autoland/rev/9f349b686811
FOG should report the Update Channel not Build Channel r=janerik

Comment 4

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1710664) for causing gtest failures in FogInitDoesntCrash
Backout link: https://hg.mozilla.org/integration/autoland/rev/1573cb8af7c7c3a54825925edbddb884091b763e
Push with failures, failure log.

Comment 5

[Chris H-C :chutten]

Weird. Passed on my machine. Lemme rebase and try again.

Comment 6

[Chris H-C :chutten]

[task 2021-05-19T15:16:45.142Z] 15:16:45  WARNING -  TEST-UNEXPECTED-FAIL | FOG.FogInitDoesntCrash | Expected equality of these values:
[task 2021-05-19T15:16:45.143Z] 15:16:45     INFO -    NS_OK
[task 2021-05-19T15:16:45.143Z] 15:16:45     INFO -      Which is: 4-byte object <00-00 00-00>
[task 2021-05-19T15:16:45.143Z] 15:16:45     INFO -    fog_init(&empty, &empty)
[task 2021-05-19T15:16:45.143Z] 15:16:45     INFO -      Which is: 4-byte object <FF-FF 00-80> @ /builds/worker/checkouts/gecko/toolkit/components/glean/gtest/TestFog.cpp:39

0x8000FFFF is NS_ERROR_UNEXPECTED which FOG code doesn't return. So this is a failure in something fog_init calls.

A likely hypothesis would be the new GetCharPref I added. My guess is that OSX gtest builds (for whatever reason) don't provide a default branch value for app.update.channel whereas every other platform does.

Well, a sensible default value in the case that there is no pref value would be the value "unknown" so let's go with that.

Comment 7

[Chris H-C :chutten]

Attachment: Bug 1710664 - Ensure in situations where libpref is cranky FOG still has a channel r?janerik!

Depends on D114982

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/fba1c3067d14
https://hg.mozilla.org/mozilla-central/rev/3dc837dc05fd
https://hg.mozilla.org/mozilla-central/rev/1ce954d52382