1710757 - baseprofiler/core/ProfileBufferEntry.cpp#627 : printf("%#llx") doesn't output "0x<number>" anymore

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P1)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

This makes baseprofiler native stacks look like "%#llx" without address.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1710757 - Fix baseprofiler native-frame output - r?florian

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Actually, '#' was valid, and allowed "alternative" representations, in this case it used to add the "0x" prefix.
But I won't chase what happened with printf. I'll just remove '#' and add the explicit "0x", it Works For Me™.

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Before: https://share.firefox.dev/2RaSPcZ (shows "%#llx")
Without '#': https://share.firefox.dev/2RaSPcZ (shows naked addresses)
With "0x": https://share.firefox.dev/3y3uwhz (shows function names) 🎉

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/441223763635
Fix baseprofiler native-frame output - r=florian

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1690167

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/441223763635

Comment 7

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 9221469 [details]
Bug 1710757 - Fix baseprofiler native-frame output - r?florian

Beta/Release Uplift Approval Request

• User impact if declined: Users of the Firefox Profiler will get less-useful startup profiles.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not risky: It's only changing a printf format argument.
• String changes made/needed:

Comment 8

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

(In reply to Gerald Squelart [:gerald] (he/him) from comment #7)

• Is this code covered by automated tests?: No

To be more precise: We have automated tests that run this code, so I'm confident it doesn't crash or makes profiles worse, but the tests don't check for the exact output of this line -- Which is why we didn't catch the regression.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9221469 [details]
Bug 1710757 - Fix baseprofiler native-frame output - r?florian

Approved for 89.0b12.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/371eddbe3443