1710810 - devtools/client/framework/test/browser_toolbox_options_disable* tests fails with JSWindowActor based targets

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Alexandre Poirot [:ochameau]]

Bug 1698891 when enabling JSWindowActor based first target, browser_toolbox_options_disable*.js tests start failing.

It seems to related to us restoring the disabling state on target destroy.
If I disable the restore, the test pass. But we should restore the tests, at least when the toolbox closes. It isn't clear why re-enabling the flags on JSWindowActor destruction makes the test fail.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Framework' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Hubert Boma Manilla (:bomsy)]

Just adding a note on the specific tests which seem to fail

• browser_toolbox_options_disable_cache-01.js
• browser_toolbox_options_disable_cache-02.js
• browser_toolbox_options_disable_js.js

Comment 3

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1710810 - [devtools] Setting the cache disabled flag using the target configuration actor r=ochameau

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e9fff5a4ce2
[devtools] Setting the cache disabled flag using the target configuration actor r=ochameau,devtools-backward-compat-reviewers

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/2e9fff5a4ce2