1710858 - Deprecate featureConfig.enabled

Status: RESOLVED FIXED

(Firefox :: Nimbus Desktop Client, enhancement, P1)

Description

[Kate Hudson :k88hudson]

In order to support a consistent experience for all feature variables, we want to move away from the .enabled property and just have it be declared in the variables section if needed.

• Update manifest schema
• Change any existing features to have an enabled variable v.s. a special enabled property
• Convert isEnabled() to call getVariable
• Add some migration code to handle both cases
• Update remote settigns rollout schema + rollout code not to used .enabled
• Add a test to make sure don't break existing experiments / rollouts in flight

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1710858 - Deprecate featureConfig.enabled in Experiment/Rollout definition

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03d170b7fb27
Deprecate featureConfig.enabled in Experiment/Rollout definition r=k88hudson

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset 03d170b7fb27 (Bug 1710858) for causing failures in browser_browserGlue_upgradeDialog.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=03d170b7fb27d2ed449a19ad74e3a000a24892f7&selectedTaskRun=Nx4YXxSzQ1SElBfTa3UBMA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=341091067&repo=autoland&lineNumber=2964

Backout: https://hg.mozilla.org/integration/autoland/rev/273f8a4ef8db766b593968602906e69981f43362

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77dca71aade8
Deprecate featureConfig.enabled in Experiment/Rollout definition r=k88hudson

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/77dca71aade8