1710887 - Printing an external page without opening it leads to crash of Tab

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Nils Reibold]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.214 Safari/537.36

Steps to reproduce:

I used Javscript functions for printing as described in:
https://developer.mozilla.org/en-US/docs/Web/Guide/Printing#print_an_external_page_without_opening_it

Actual results:

The printing preview opened. After closing it (cancel / print out) the Tab becomes unresponsive.
This may be connected to the onafterprint event firing already while opening the printing preview.
After page reload the behaviour seemed to be as expected (in another example some JS execution did not work)

Expected results:

After printing / canceling in the printing preview menu the website should still be responsive.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Printing: Output' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

I can repro, thanks. Simple example: http://crisal.io/tmp/print-external-page.html

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1710887 - Make modal state handling in window.print() more reliable. r=smaug

If afterprint removes the window we're printing, we'd call
LeaveModalState() without a top window, and never leave the modal state.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8b0ddb12df7
Make modal state handling in window.print() more reliable. r=smaug

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c8b0ddb12df7