1710910 - Reduce the size of the close button on infobars and use the correct smaller close icon for tabs

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Katie pointed out to me that the close icon for infobars should be reduced in size to use close-12.svg, and the tab's close icon which is already 12px by 12px isn't using close-12.svg, which has better pixel alignment at that size.

While working on this we noticed that the tab close button isn't using the --toolbarbutton-icon-fill color.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1710910 - Reduce the size of the close icon for infobars and use the correct smaller close icon for tabs

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S4. However, the following bug duplicate has higher severity:

• Bug 1711709: S3

:jaws, could you consider increasing the severity of this bug to S3?

For more information, please visit auto_nag documentation.

Comment 4

[Ahmed Al-Ohally]

[redacted - mhoye]

Comment 5

[Ahmed Al-Ohally]

[redacted - mhoye]

Comment 6

[Ahmed Al-Ohally]

[redacted - mhoye]

Comment 7

[Ahmed Al-Ohally]

[redacted - mhoye]

Comment 8

[Ahmed Al-Ohally]

[redacted - mhoye]

Comment 9

[Ahmed Al-Ohally]

[redacted - mhoye]

Comment 10

[Ahmed Al-Ohally]

[redacted - mhoye]

Comment 11

[Ahmed Al-Ohally]

[redacted - mhoye]

Comment 12

[Ahmed Al-Ohally]

[redacted - mhoye]

Comment 13

[Ahmed Al-Ouhally 2]

[redacted - mhoye]

Comment 14

[Ahmed Al-Ouhally 2]

[redacted - mhoye]

Comment 15

[Ahmed Al-Ouhally 2]

[redacted - mhoye]

Comment 16

[Dão Gottwald [:dao]]

(In reply to Release mgmt bot [:suhaib / :marco/ :calixte] from comment #3)

The severity field for this bug is set to S4. However, the following bug duplicate has higher severity:

• Bug 1711709: S3

:jaws, could you consider increasing the severity of this bug to S3?

For more information, please visit auto_nag documentation.

S4 seems right for this.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a56f7bf6fb9b
Reduce the size of the close icon for infobars and use the correct smaller close icon for tabs. r=sfoster,mstriemer,desktop-theme-reviewers,dao

Comment 18

[Sandor Molnar[:smolnar]]

Backed out for causing linux build bustage

Backout link: https://hg.mozilla.org/integration/autoland/rev/1b5de4d4f7b727333eb6962dcee9d7725efe3199

Push with failures

Failure log

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17805375f92a
Reduce the size of the close icon for infobars and use the correct smaller close icon for tabs. r=sfoster,mstriemer,desktop-theme-reviewers,dao

Comment 20

[Sandor Molnar[:smolnar]]

Backed out by mistake.
Relanded the changes, sorry

Comment 21

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/17805375f92a

Comment 22

[Cosmin Sabou [:CosminS]]

Backed out changeset 17805375f92a (Bug 1710910) for causing Bug 1818233.

Backout link: https://hg.mozilla.org/integration/autoland/rev/65df162e540fcc392bd0f8fb020abbfc7f60ecee

Comment 23

[Norisz Fay [:noriszfay]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/65df162e540f

Comment 24

[:prathiksha]

I'll look into this. Thanks for flagging!

Comment 25

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:prathiksha, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 26

[Sam Foster [:sfoster] (he/him)]

I'll see if I can gets this re-landed.

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5b2f3b5a89b
Reduce the size of the close icon for infobars and use the correct smaller close icon for tabs r=mstriemer,desktop-theme-reviewers,dao

Comment 28

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c5b2f3b5a89b