Closed Bug 1710912 Opened 4 years ago Closed 3 years ago

[wpt-sync] Sync PR 28977 - update createConicGradient to use radians as |startAngle|

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28977 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28977
Details from upstream follow.

b'Yi Xu <yiyix@chromium.org>' wrote:

update createConicGradient to use radians as |startAngle|

All canvas context 2d API uses radiants for angle. To keep the
API consistent, update createConicGradient to use radians as well.

For similar reason, since all angles in canvas is related to the x-axis,
rotate the conic gradient by 90 degrees such that the gradient starts
from x-axis.

Bug:1208511

Change-Id: I3320bcaac57d18241fb05ca7068f6d30460bd98b

Reviewed-on: https://chromium-review.googlesource.com/2891049
WPT-Export-Revision: 7e223e9471fba5df13b9b64fe7387dba2e302c71

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests and 1 subtests

Status Summary

Firefox

OK : 6
FAIL: 6

Chrome

OK : 6
PASS: 6

Safari

OK : 6
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.negative.rotation.html
Conic gradient function exists: FAIL (Chrome: PASS, Safari: FAIL)
/html/canvas/element/fill-and-stroke-styles/2d.gradient.conic.negative.rotation.html
Conic gradient function exists: FAIL (Chrome: PASS, Safari: FAIL)
/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.negative.rotation.worker.html
Conic gradient function exists: FAIL (Chrome: PASS, Safari: FAIL)
/html/canvas/element/fill-and-stroke-styles/2d.gradient.conic.positive.rotation.html
Conic gradient function exists: FAIL (Chrome: PASS, Safari: FAIL)
/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.positive.rotation.html
Conic gradient function exists: FAIL (Chrome: PASS, Safari: FAIL)
/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.positive.rotation.worker.html
Conic gradient function exists: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a12e4239116f [wpt PR 28977] - update createConicGradient to use radians as |startAngle|, a=testonly https://hg.mozilla.org/integration/autoland/rev/eb474115b694 [wpt PR 28977] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a12e4239116f
https://hg.mozilla.org/mozilla-central/rev/eb474115b694

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.