1710917 - Consider removing checks on addon ids related to the SVG context-fill after all existing extensions using it are migrated to the new WebExtensionPolicy.isPrivileged check

Status: RESOLVED FIXED

(Core :: SVG, task)

Description

[Luca Greco [:rpl] [:luca] [:lgreco] (PTO -> Jan 7 2026)]

This is a follow up task from Bug 1394579.

As mentioned in Bug 1394579 comment 25:

we are going to allow contex-fill behind a separate check for WebExtensionPolicy.isPrivileged but we didn't remove yet the existing checks for @mozilla.com / @mozilla.org addon id suffixes, because we should double-check that the line extension that were leveraging those checks have been signed to be able to use the IsPrivileged condition.

Once we verified there are no other Mozilla extensions that are leveraging the checks on the Mozilla addon id suffixes, we should ideally rip that off and leave only the WebExtensionPolicy.isPrivileged one.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco] (PTO -> Jan 7 2026)]

Attachment: Bug 1710917 - Introduced internal:svgContextPropertiesAllowed webextension permission. r?dholbert!,mixedpuppy!

This patch does change the extension-related special case in SVGContextPaint::IsAllowedForImageFromURI
to check the "internal:svgContextPropertiesAllowed" extension permission, and move the existing
criteria in the Extension class (which takes care of adding the internal permission when those
criteria as met).

This patch does not contain yet a new explicit test case for the new internal permission (which is
part of the patch build on top of this one and attached to the same bugzilla issue), but it does
pass the existing mochitest-chrome (test_chrome_ext_svg_context_fill.html).

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco] (PTO -> Jan 7 2026)]

Attachment: Bug 1710917 - Add internal:svgContextPropertiesAllowed permission to Mozilla line extensions. r?mixedpuppy!

This patch does ensure we also add the new "internal:svgContextPropertiesAllowed" permission
to the Mozilla line extensions (when the extension is signed with a non privileged XPI certificate
and has "line" in the recommendations state).

Also add a note to the mochitest-chrome test that covers the svg context-properties behavior
on extensions svg files, to point out that this scenario is actually covered by the sum of the
mochitest and the additional test added to the AOM xpcshell test names test_recommendations.js.

Depends on D115835

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f76f82499fc9
Introduced internal:svgContextPropertiesAllowed webextension permission. r=dholbert,mixedpuppy

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f76f82499fc9