"WebDriver:NewSession" doesn't return empty proxy capability
Categories
(Remote Protocol :: Marionette, defect, P3)
Tracking
(firefox90 fixed)
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
Details
Attachments
(1 file)
As noticed by Julian in the review of bug 1703805 there are some proxy related webdriver tests in new_session/response.py marked as failing:
I inappropriately tagged them as being caused by bug 1703805, which is wrong.
The underlying reason here is that we do not return the default proxy capability due to optimizing away an empty object:
To get this fixed we will have to do it similarly as for timeouts:
|
Assignee | |
Comment 1•3 years ago
|
||
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0cc6b9d31a1d [marionette] Always return proxy capabilities for WebDriver:NewSession. r=marionette-reviewers,webdriver-reviewers,jdescottes
|
||
Comment 3•3 years ago
|
||
Backed out for causing failures at test_session.js and timeouts.py.
Backout link: https://hg.mozilla.org/integration/autoland/rev/0c2dd7ce83dab71e6dbd66c1a6f4fdacaf0a71ef
Failure log: https://treeherder.mozilla.org/logviewer?job_id=339933121&repo=autoland&lineNumber=95334
https://treeherder.mozilla.org/logviewer?job_id=339933054&repo=autoland&lineNumber=4098
|
|
Assignee | |
Comment 4•3 years ago
|
||
There is some kind of bug in the marshal() implementation that results in problems when passing through the proxy instance. To be in-par with timeouts it's enough to just set an empty object for the proxy capability for now.
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
|
||
Updated•1 year ago
|
Description
•