1710953 - Prepare to remove self-hosting zone

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Ted Campbell [:tcampbell]]

Preliminary patches for Bug 1688794. Try to simplify selfhosted.js and its parsing now.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1710953 - Set discard-source when compiling self-hosted source. r?arai!

Instead of setting the realm-behaviour on the self-hosted realm, set it on the
CompileOptions directly when parsing. This is in preparation for removal of the
self-hosted Zone. Also set NoScriptRVal at same time.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1710953 - Remove unnecessary std_Symbol variable. r?arai!

GetIntrinsic ensures that using Symbol from self-hosting always gets the
original value so std_Symbol is not helpful. Add a simple test case just to
confirm this is safe.

Depends on D115028

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f51b573ef62b
Set discard-source when compiling self-hosted source. r=arai
https://hg.mozilla.org/integration/autoland/rev/0fb6461e2c53
Remove unnecessary std_Symbol variable. r=arai

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f51b573ef62b
https://hg.mozilla.org/mozilla-central/rev/0fb6461e2c53

Comment 5

[Ted Campbell [:tcampbell]]

Attachment: Bug 1710953 - Avoid making all cloned inner self-hosted functions extended. r?arai!

Instead of forcing the FUNCTION_EXTENDED flag while cloning inner functions, we
should use the original flags. To do this we must fix an edge-case around bound
functions by using a $ prefix. The change avoids unnecessary extended function
usage and prepares us to directly instantiate from a Stencil.

Comment 6

[Ted Campbell [:tcampbell]]

Attachment: Bug 1710953 - Avoid lambdas in top-level selfhosted.js code. r?arai!

Replace uses of lambdas in the top-level body of self-hosting (that is executed
at startup) in order to simplify things in future when we use Stencil for self
hosting. This adds a couple of entries to the per-global intrinsics holder only
if the Intl APIs are used but it neglible.

Depends on D115556

Comment 7

[Ted Campbell [:tcampbell]]

Attachment: Bug 1710953 - Use consistent names for Intl localeData methods. r?anba!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3155eaf46e9c
Avoid making all cloned inner self-hosted functions extended. r=arai
https://hg.mozilla.org/integration/autoland/rev/83a66cdc3906
Avoid lambdas in top-level selfhosted.js code. r=arai

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9aa5b9559855
Use consistent names for Intl localeData methods. r=anba

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/3155eaf46e9c
https://hg.mozilla.org/mozilla-central/rev/83a66cdc3906
https://hg.mozilla.org/mozilla-central/rev/9aa5b9559855

Comment 11

[Ted Campbell [:tcampbell]]

Attachment: Bug 1710953 - Allow parsing without active realm. r?arai!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc35f406c576
Allow parsing without active realm. r=arai

Comment 13

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/bc35f406c576

Comment 14

[Ted Campbell [:tcampbell]]

Attachment: Bug 1710953 - Factor js::ScopeIndex to its own file. r?arai!