1710975 - OuterDocAccessible::ChildCount probably returns wrong value on non-Windows platforms

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[James Teh [:Jamie]]

OuterDocAccessible::ChildCount is inside a Windows ifdef. I haven't tested this, but I'm fairly sure that means it'll return 0 on non-Windows for remote documents.

Comment 1

[James Teh [:Jamie]]

Also, OuterDocAccessible::ChildAt has a bunch of Windows specific code which isn't necessary because it calls AccessibleWrap::LocalChildAt, not OuterDocAccessible::LocalChildAt. My bad; I confused things during the review.

Comment 2

[James Teh [:Jamie]]

Attachment: Bug 1710975: Fix child/sibling functions regarding top level remote documents.

1. ChildCount was inside a Windows ifdef, but it needs to be available on all platforms.
2. ChildAt included code for Windows which isn't necessary because it calls AccessibleWrap::LocalChildAt, not OuterDocAccessible::LocalChildAt (where the Windows specific RemoteAccessibleWrap stuff is implemented).

Comment 3

[James Teh [:Jamie]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1677422fd21d149f1fac0aa8c03eb3076ebe7fe2

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59a17ca79018
Fix child/sibling functions regarding top level remote documents. r=eeejay

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for assertion failures on RemoteAccessibleBase.h

backout: https://hg.mozilla.org/integration/autoland/rev/0e275c481d224268397ef8848becb4770e547ecf

push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=QoU9R7G8RIW-e3NxF3q73Q.0&revision=59a17ca79018310a8753f3da61402de75fc1deca

failure log: https://treeherder.mozilla.org/logviewer?job_id=340404755&repo=autoland&lineNumber=2757

[task 2021-05-21T03:33:16.654Z] 03:33:16 INFO - GECKO(3079) | Assertion failure: !IsDoc(), at /builds/worker/workspace/obj-build/dist/include/mozilla/a11y/RemoteAccessibleBase.h:61
[task 2021-05-21T03:33:16.657Z] 03:33:16 INFO - Initializing stack-fixing for the first stack frame, this may take a while...
[task 2021-05-21T03:33:24.370Z] 03:33:24 INFO - GECKO(3079) | #01: mozilla::a11y::RemoteAccessibleBase<mozilla::a11y::RemoteAccessible>::RemoteNextSibling() const [accessible/ipc/RemoteAccessibleBase.h:61]
[task 2021-05-21T03:33:24.371Z] 03:33:24 INFO - GECKO(3079) | #02: mozilla::a11y::Pivot::SearchForward(mozilla::a11y::AccessibleOrProxy&, mozilla::a11y::PivotRule&, bool) [accessible/base/Pivot.cpp:137]
[task 2021-05-21T03:33:24.371Z] 03:33:24 INFO - GECKO(3079) | #03: -[MOXSearchInfo getMatchesForRule:] [accessible/mac/MOXSearchInfo.mm:118]
[task 2021-05-21T03:33:24.372Z] 03:33:24 INFO - GECKO(3079) | #04: -[MOXSearchInfo performSearch] [accessible/mac/MOXSearchInfo.mm:356]
[task 2021-05-21T03:33:24.372Z] 03:33:24 INFO - GECKO(3079) | #05: -[mozAccessible moxUIElementCountForSearchPredicate:] [accessible/mac/mozAccessible.mm:887]
[task 2021-05-21T03:33:24.373Z] 03:33:24 INFO - GECKO(3079) | #06: -[MOXAccessibleBase accessibilityAttributeValue:forParameter:] [accessible/mac/MOXAccessibleBase.mm:349]
[task 2021-05-21T03:33:24.373Z] 03:33:24 INFO - GECKO(3079) | #07: mozilla::a11y::xpcAccessibleMacInterface::GetParameterizedAttributeValue(nsTSubstring<char16_t> const&, JS::Handle<JS::Value>, JSContext*, JS::MutableHandle<JS::Value>) [accessible/xpcom/xpcAccessibleMacInterface.mm:173]
[task 2021-05-21T03:33:24.374Z] 03:33:24 INFO - GECKO(3079) | #08: NS_InvokeByIndex [/Users/cltbld/tasks/task_1621557427/build/application/Firefox NightlyDebug.app/Contents/MacOS/XUL + 0x1d87de]
[task 2021-05-21T03:33:24.374Z] 03:33:24 INFO - GECKO(3079) | Exiting due to channel error.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f85d267b97f
Fix child/sibling functions regarding top level remote documents. r=eeejay

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7f85d267b97f