1711050 - Optimize intersection observers notification in SeaMonkey 2.53

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Frank-Rainer Grahl (:frg)]

buc and tomman tracked down performance problems on some websites. It seems the notify for intersection observers is quite costly and might currently be unnecessary for chrome uris.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1711050-nsrefreshdriveroptimize-2538.patch

Currently for 2.53 branch only. I am a bit uneasy of this but if it helps with performance on slower systems so be it. Tested with some logging enabled (now ifed out) and for some time in 2.53.8b1 pre now

buc do you think this should be/ is still needed in the release?

Comment 2

[Dmitry Butskoy (:buc)]

Comment on attachment 9221783 [details] [diff] [review]
1711050-nsrefreshdriveroptimize-2538.patch

This patch is already in Fedora for 2.53.7, so it can be considered well tested.

Certainly this is needed, because it fixes various potential problems (including performance) that are relevant to SeaMonkey.

Firefox uses e10s, so an animation (if any) in the chrome is handled by the "parent" process, which is isolated from the "content" processes. In SeaMonkey all is handled by the same process, which is probably a reason why content of a page appears as a "sub-document" of the chrome, which should never be happen. Fortunately it seems that currently this situation spoils the intersection observers only, and now this is fixed by the patch.

Comment 3

[Ian Neal]

Comment on attachment 9221783 [details] [diff] [review]
1711050-nsrefreshdriveroptimize-2538.patch

[Triage Comment]
Thanks to buc / tomman for their work
r/a=me

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/-/commit/eadf83268e409a708d47d1e68d34d551fd266d2b
Do not notify intersection observers for chrome uris. r=IanN a=IanN