Closed Bug 1711076 Opened 2 years ago Closed 2 years ago

Difficult to diagnose perf differences caused by GCs before a profile starts

Categories

(Core :: JavaScript: GC, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: sfink, Assigned: sfink)

Details

Attachments

(1 file)

When trying to figure out why a GC scheduling-related patch regressed things, I was looking at browsertime warm profiles of pre-patch and post-patch runs. They showed pretty much nothing of interest, just the changed behavior that was a downstream result of something happening before.

What was somewhat helpful was knowing that there had been more or fewer GCs before the profile. (The difference only showed up in warm profiles, not cold ones, which is consistent with something earlier changing things.) A simple way of exposing that is to record the major and minor GC numbers.

This doesn't seem universally useful enough to actually expose in the hover text for a profile, but I could still get it from the context menu by copying the full marker json.

Assignee: nobody → sphink
Status: NEW → ASSIGNED
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c0e7224e6b5b
Add minor/major GC counts to profiles r=jonco
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.