1711086 - Pocket panel adding tags after a max char limit fails if you're using a dropdown tag

Status: RESOLVED FIXED

(Firefox :: Pocket, defect, P3)

Description

[Scott [:thecount] Downe]

Str:

1. Open the Pocket panel on a story page while logged in.
2. Attempt to add a really long tag, and hit "save"
3. Clear your long tag, and try adding a new tag.
4. Find a tag that creates a dropdown, I use "test" as it creates a dropdown for me.
5. Click the test item in the dropdown.
6. Click save.

Expected: should save the tag test.
Actual: it does not.

I've investigated it enough to know that this is an issue in how and when we validate and clear errors. We don't do it unless the user types something. Which didn't happen in the case of clicking a dropdown tag.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1711086 - Fixing Pocket panel tag error message

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0cb52fd052b
Fixing Pocket panel tag error message r=gvn

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b0cb52fd052b