1711296 - very low contrast on container icons in dark theme preferences page

Status: VERIFIED FIXED

(Toolkit :: Preferences, defect, P3)

Description

[Tim Nguyen :ntim]

Attachment: image.png

maybe bug 1394579 helps with this, not sure.

Comment 1

[Tim Nguyen :ntim]

[Tracking Requested - why for this release]: big accessibility regression

Comment 2

[Tim Nguyen :ntim]

Not just the container icons have low contrast, the circle to indicate the selected item also has bad contrast.

Comment 3

[:Gijs (he/him)]

Attachment: Pre-1709641

(In reply to Tim Nguyen :ntim from comment #0)

maybe bug 1394579 helps with this, not sure.

No extensions are involved.

(In reply to Tim Nguyen :ntim from comment #1)

[Tracking Requested - why for this release]: big accessibility regression

I mean, not really - the previous version was also pretty invisible in dark mode.

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1711296 - use general in-content pref variables for icon colours and indicating selection, focus and active state in the container settings, r?ntim

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19cd65f20975
use general in-content pref variables for icon colours and indicating selection, focus and active state in the container settings, r=ntim,preferences-reviewers

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See What Do You Triage for more information

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/19cd65f20975

Comment 8

[Pascal Chevrel:pascalc (PTO until Sept 2)]

I tracked this bug thinking that this was a new regression caused by proton but we have the same accessibility bug in 88 with the dark mode set at the OS level, so untracking and setting back to P3.

Comment 9

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest Nightly build 90.0a1 (2021-05-21) on Mac, Windows and Ubuntu.