macOS native context menu doesn't underline access keys
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
People
(Reporter: bugzilla.mozilla.org, Unassigned)
Details
Attachments
(1 file)
|
331.34 KB,
image/png
|
Details |
firefox-context-menu-comparison.png
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:89.0) Gecko/20100101 Firefox/89.0
Steps to reproduce:
-
set 'widget.macos.native-context-menus' in 'about:config' to 'false', triggered a context menu
-
set 'widget.macos.native-context-menus' in 'about:config' to 'true', triggered a context menu
Actual results:
- context menu was shown with access keys underlined
- context menu was shown without any access keys underlined
Expected results:
- as expected
- context menu should've been shown with access keys underlined
|
||
Comment 1•4 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Core::Widget: Cocoa' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
|
||
Comment 2•4 years ago
|
||
Copying the explanation I put in the other bug you filed
Access keys used to work in Firefox because we were using a multiplatform implementation across different operating systems, including macOS. By using native menus, we follow the same behavior of other apps on macOS. That means that access keys are not displayed as such (i.e. underlined), and don't work to trigger commands.
With that said, access keys were never displayed underlined on macOS, even with non native menus?
|
Reporter | |
Comment 4•4 years ago
|
||
With that said, access keys were never displayed underlined on macOS, even with non native menus?
Ooh! Interesting!
I'm not sure why they are displayed on my machine (macOS catalina, firefox 89) 🤔
(for non-native menus)
|
||
Comment 5•4 years ago
•
|
||
(In reply to Sujeet Gholap from comment #4)
With that said, access keys were never displayed underlined on macOS, even with non native menus?
Ooh! Interesting!
I'm not sure why they are displayed on my machine (macOS catalina, firefox 89) 🤔
(for non-native menus)
Do you have ui.key.menuAccessKey set to a custom value, like 18 (you can check in about:config ) ? (changing it doesn't take effect until after a restart of Firefox, fwiw)
|
|
Reporter | |
Comment 6•4 years ago
|
||
Do you have
ui.key.menuAccessKeyset to a custom value, like 18 (you can check in about:config ) ? (changing it doesn't take effect until after a restart of Firefox, fwiw)
Aha! That's it!! 🎉🎉
Yep, I had ui.key.menuAccessKey set to a custom value.
Thanks a ton for pointing out that changing it doesn't take effect until after a restart!
I had spun up a new profile and fiddled with it and didn't see any change. Now I know why I didn't!
You are awesome!
Description
•