Closed
Bug 1711390
Opened 4 years ago
Closed 4 years ago
Use AppConstants in chatZilla
Categories
(SeaMonkey :: Chat, task)
SeaMonkey
Chat
Tracking
(seamonkey2.53+ fixed)
RESOLVED
FIXED
seamonkey 2.88
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.9)
Attachments
(1 file, 1 obsolete file)
|
2.91 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Make use of AppConstants.jsm in chatZilla to determine the client.platform
Whilst here removed the unused client.hostPlatform and __cz_guid
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.9
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Attachment #9222081 -
Flags: review?(frgrahl)
Attachment #9222081 -
Flags: approval-comm-release?
Attachment #9222081 -
Flags: approval-comm-esr60?
Unbitrot patch
Attachment #9222081 -
Attachment is obsolete: true
Attachment #9222081 -
Flags: review?(frgrahl)
Attachment #9222081 -
Flags: approval-comm-release?
Attachment #9222081 -
Flags: approval-comm-esr60?
Attachment #9223139 -
Flags: review?(frgrahl)
Attachment #9223139 -
Flags: approval-comm-release?
Attachment #9223139 -
Flags: approval-comm-esr60?
|
||
Comment 3•4 years ago
|
||
Comment on attachment 9223139 [details] [diff] [review]
1711390-irc-appconstants-v1_1-2539.patch
LGTM
Attachment #9223139 -
Flags: review?(frgrahl)
Attachment #9223139 -
Flags: review+
Attachment #9223139 -
Flags: approval-comm-release?
Attachment #9223139 -
Flags: approval-comm-release+
Attachment #9223139 -
Flags: approval-comm-esr60?
Attachment #9223139 -
Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/3ae4995f02d3
Use AppConstants in chatZilla. r=frg
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
|
|
||
Updated•4 years ago
|
status-seamonkey2.53:
--- → affected
tracking-seamonkey2.53:
--- → ?
Target Milestone: --- → seamonkey 2.88
|
|
||
Updated•4 years ago
|
Whiteboard: SM2.53.9
|
|
||
Comment 5•4 years ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/fa2a3aa3e0498cea200519d2fe245cc07731445d
Use AppConstants in chatZilla. r=frg a=frg
|
|
||
Updated•4 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•