1711430 - The second screen of the "about:welcome" page is skipped if a double click action is performed on the "Not now" secondary button from the first screen

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P2)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:

• Firefox Beta 89.0b13 - Build ID: 20210516190025
• Firefox Nightly 90.0a1 - Build ID: 20210516091748

[Affected Platforms]:

• Windows 10 x64
• Windows 8.1 x64
• macOS 10.15.7
• Linux Mint 20 x64

[Prerequisites]:

• Have a new Firefox profile.

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Double click the "Now now" secondary button.
3. Observe the behavior.

[Expected result]:

• The second screen of the "about:welcome" page is displayed.

[Actual result]:

• The third screen of the "about:welcome" page is displayed instead.

[Regression Window]:

• Since this issue is not reproducible with the Firefox Nightly build from 2021/05/17, using the Mozregression tool I have managed to find the following regression window:
  Last good revision: 25854de1a92c7fec1fcf01f271189cce5008bd74
  First bad revision: 88ca58d4c08e073fd52f332804a0da9a7d37b626
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=25854de1a92c7fec1fcf01f271189cce5008bd74&tochange=88ca58d4c08e073fd52f332804a0da9a7d37b626

From the pushlog it seems that bug 1698204 has caused this behavior.

[Additional Notes]:

• If a triple-click action is performed on the "Now now" secondary button from the first screen of the "about:welcome" page, the background image remains displayed and the user is not redirected to the "about:newtab" page.
• This issue is reproducible on the first and the second screen of the new users Onboarding.
• This issue is not reproducible with the Upgrade Onboarding modals.
• Attached a screen recording of the issue.

Comment 1

[Punam Dahiya [:pdahiya]]

the issue appears to be fallout of 1 second wait to allow noodles and other screen elements to transition out, before screen navigates forward and transition in. This 1 second wait gives enough time to invoke multiple click handlers and move screen index forward

https://searchfox.org/mozilla-central/source/browser/components/newtab/content-src/aboutwelcome/components/MultiStageAboutWelcome.jsx#87

Comment 2

[Ed Lee :Mardak]

We do setTransition("out"), so we can probably check

const handleTransition = () => {
  if (transition === "out") return;"

?

https://searchfox.org/mozilla-central/rev/5359952d8b0be3e706e8c943c2bef2674723b8a9/browser/components/newtab/content-src/aboutwelcome/components/MultiStageAboutWelcome.jsx#72

Comment 3

[Ed Lee :Mardak]

Attachment: Bug 1711430 - Ignore multiple welcome button clicks while transitioning out r?pdahiya

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e184f7aca74b
Ignore multiple welcome button clicks while transitioning out r=pdahiya

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e184f7aca74b

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (90.0b1 Build ID - 20210601190019) installed on Windows 10 x64, macOS 10.15.7, and Linux Mint 20 x64. Now I can confirm that the second screen of the "about:welcome" page is no longer skipped if a double click action is performed on the "Not now" secondary button from the first screen.