1711442 - Crash in [@ mozilla::dom::Document::SetLastFocusTime]

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Gabriele Svelto [:gsvelto]]

Crash report: https://crash-stats.mozilla.org/report/index/4899ba93-5f68-4d54-84a2-9cef50210515

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(!aFocusTime.IsNull())

Top 10 frames of crashing thread:

0 xul.dll mozilla::dom::Document::SetLastFocusTime dom/base/Document.cpp:6093
1 xul.dll nsFocusManager::SetFocusedWindowInternal dom/base/nsFocusManager.cpp:5164
2 xul.dll nsFocusManager::Focus dom/base/nsFocusManager.cpp:2538
3 xul.dll nsFocusManager::WindowRaised dom/base/nsFocusManager.cpp:776
4 xul.dll mozilla::AppWindow::WindowActivated xpfe/appshell/AppWindow.cpp:3000
5 xul.dll mozilla::AppWindow::WidgetListenerDelegate::WindowActivated xpfe/appshell/AppWindow.cpp:3362
6 xul.dll nsWindow::ProcessMessage widget/windows/nsWindow.cpp:6051
7 xul.dll static nsWindow::WindowProcInternal widget/windows/nsWindow.cpp:5024
8 xul.dll static nsWindow::WindowProc widget/windows/nsWindow.cpp:4977
9 user32.dll int64_t UserCallWinProcCheckWow 

Not a new crash since we have reports going back a long time.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Hmm, how can this happen. We pass TimeStamp::Now() to SetLastFocusTime.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

According to the pref log, privacy.fuzzyfox.enabled is not set to true. So,
https://searchfox.org/mozilla-central/rev/443f87caa5fadba920b0382e12874693d6c6133a/mozglue/misc/TimeStamp.cpp#118-119,131-132
may return null timestamp? It seems that it's introduced by bug 1432429.

Comment 3

[Tom Ritter [:tjr] (OOTO until April)]

I see 7 reports, all quite recent. Unless this meets the bar for faster action, this will probably be resolved when I rip out Fuzzyfox in a month+half.

Comment 4

[Wayne Mery (:wsmwk)]

Bit of a spike in 91.0a1 and 90.0b12
https://crash-stats.mozilla.org/signature/?product=Firefox&signature=mozilla%3A%3Adom%3A%3ADocument%3A%3ASetLastFocusTime&date=%3E%3D2021-06-06T02%3A04%3A00.000Z&date=%3C2021-07-06T02%3A04%3A00.000Z#graphs

Comment 5

[Tom Ritter [:tjr] (OOTO until April)]

I'm going to resolve this as fixed; if the crashes keep occurring post-fuzzyfox-ripout then we'll have to investigate again.