1711462 - Evict texture cache items when deleting image keys

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Nicolas Silva [:nical]]

Once an image key is gone its textue cache entry can never be used again. The more eagerly we evict useless cache items the better for cache pressure and memory usage overall.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1711462 - Evict non-manual texture cache items when nothing holds on to them. r=#gfx-reviewers

Making room in the texture cache as early as possible reduces the likelihood of allocating extra textures. It will also let us discard unused cached render tasks more aggressively in a folowup patch.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fe9e5e3e89e
Evict non-manual texture cache items when nothing holds on to them. r=gfx-reviewers,gw

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for reftest failures on svg-paint-rect-changes.html along with Bug 1705024.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1705024#c3

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28c6110d23c9
Backed out 2 changesets (bug 1711462, bug 1705024) for failures on  svg-paint-rect-changes.html. CLOSED TREE

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ed9d74e8c6f
Evict non-manual texture cache items when nothing holds on to them. r=gfx-reviewers,gw

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8ed9d74e8c6f