1711464 - Audit calls to nsIFocusManager.getFocusedElementForWindow

Status: RESOLVED WORKSFORME

(Core :: DOM: UI Events & Focus Handling, task, P2)

Description

[Henri Sivonen (:hsivonen)]

In particular, callers that set aDeep=true are likely Fission-incompatible.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking for Fission M7a milestone because we would like to audit the the calls soon. If any of the calls need to be fixed, we can file follow-up bugs and triage them individually (for Fission M7a, M8, MVP, or Future milestones).

https://searchfox.org/mozilla-central/search?case=true&q=getFocusedElementForWindow

Comment 2

[Henri Sivonen (:hsivonen)]

https://searchfox.org/mozilla-central/rev/5359952d8b0be3e706e8c943c2bef2674723b8a9/devtools/server/actors/highlighters/tabbing-order.js#62
Calls with true; needs a better look.

https://searchfox.org/mozilla-central/rev/5359952d8b0be3e706e8c943c2bef2674723b8a9/toolkit/content/widgets/notificationbox.js#285
Calls with false and looks parent-only. Probably OK.

https://searchfox.org/mozilla-central/rev/5359952d8b0be3e706e8c943c2bef2674723b8a9/toolkit/modules/Finder.jsm#394
Calls with true, but searching for a string seems to work, so this has to be OK somehow.

https://searchfox.org/mozilla-central/rev/5359952d8b0be3e706e8c943c2bef2674723b8a9/toolkit/modules/SelectionUtils.jsm#55
Calls with true, but selection, copy&paste, etc. seem to work, so this has to be OK somehow.

https://searchfox.org/mozilla-central/rev/5359952d8b0be3e706e8c943c2bef2674723b8a9/dom/base/nsGlobalWindowOuter.cpp#5172
Calls with false. Probably OK.

https://searchfox.org/mozilla-central/rev/5359952d8b0be3e706e8c943c2bef2674723b8a9/layout/base/PresShell.cpp#6586
Calls with false. Seems process-local. Looks OK.

https://searchfox.org/mozilla-central/rev/5359952d8b0be3e706e8c943c2bef2674723b8a9/toolkit/components/typeaheadfind/nsTypeAheadFind.cpp#1021
Calls with false, and searching seems to work, so this has to be OK somehow.

https://searchfox.org/mozilla-central/rev/5359952d8b0be3e706e8c943c2bef2674723b8a9/browser/base/content/test/general/browser_newwindow_focus.js#33
Probably OK as long as the test passes.

https://searchfox.org/mozilla-central/rev/5359952d8b0be3e706e8c943c2bef2674723b8a9/browser/base/content/test/general/browser_newwindow_focus.js#78
Probably OK as long as the test passes.

https://searchfox.org/mozilla-central/rev/5359952d8b0be3e706e8c943c2bef2674723b8a9/browser/base/content/test/general/browser_tabfocus.js#60
Seems to actually only care about the process-local element.

https://searchfox.org/mozilla-central/rev/5359952d8b0be3e706e8c943c2bef2674723b8a9/browser/base/content/test/general/browser_tabfocus.js#435
https://searchfox.org/mozilla-central/rev/5359952d8b0be3e706e8c943c2bef2674723b8a9/browser/base/content/test/general/browser_tabfocus.js#451
https://searchfox.org/mozilla-central/rev/5359952d8b0be3e706e8c943c2bef2674723b8a9/browser/base/content/test/general/browser_tabfocus.js#483
These seem to care only about the process-local element in parent.

https://searchfox.org/mozilla-central/rev/5359952d8b0be3e706e8c943c2bef2674723b8a9/browser/base/content/test/general/browser_tabfocus.js#681
This seems to care only about the process-local case in parent.

https://searchfox.org/mozilla-central/rev/5359952d8b0be3e706e8c943c2bef2674723b8a9/testing/mochitest/tests/SimpleTest/SimpleTest.js#1077
https://searchfox.org/mozilla-central/rev/5359952d8b0be3e706e8c943c2bef2674723b8a9/testing/mochitest/tests/SimpleTest/SimpleTest.js#1080
https://searchfox.org/mozilla-central/rev/5359952d8b0be3e706e8c943c2bef2674723b8a9/testing/specialpowers/content/SpecialPowersChild.jsm#1640
These are bug 1709125.

https://searchfox.org/mozilla-central/rev/5359952d8b0be3e706e8c943c2bef2674723b8a9/browser/base/content/tabbrowser.js#1424
This seems to be both non-e10s and non-Fission only.

Comment 3

[Henri Sivonen (:hsivonen)]

(In reply to Henri Sivonen (:hsivonen) from comment #2)

https://searchfox.org/mozilla-central/rev/5359952d8b0be3e706e8c943c2bef2674723b8a9/devtools/server/actors/highlighters/tabbing-order.js#62
Calls with true; needs a better look.

This was broken a few days ago, but in today's Nightly, this feature works.

Closing, since the only identified problem, bug 1709125, is already on file.