1711466 - [macOS] Firefox remains stuck if closed while the master password modal is opened and close tabs and exit window is displayed.

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect, P2)

Description

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: Screen Recording 2021-05-17 at 15.36.33.mov

Affected versions

• 90.0a1 (20210517094928)
• 89.0b13 (20210516190025)

Affected platforms

• macOS 11.3.1 ARM
• macOS 10.14

Preconditions

• Primary Password modal displayed

Steps to reproduce

1. Click on the Firefox Apple menu and select Quit Firefox.
2. Enter the password and submit or click Cancel on the Primary password prompt.
3. Try to do anything in Firefox.

Expected result

• On 88.0.1 the close tabs and quit window is displayed only after the Primary password is closed and after closing that or exiting Firefox everything works as normal.

Actual result

• Firefox cannot be closed or used.

Regression range

• I will search for one ASAP. This only reproduces if prompts.windowPromptSubDialog is set on true so it’s possible that this caused the regression.

Notes

• Attached a screen recording.
• After following the above steps Firefox can be closed by Using Force Close option from the activity monitor.
• This was marked as an S2 because the user needs to Force Quit the Firefox browser if the above steps are performed.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1711466 - do not open window-internal modal prompts if the window is in a modal state through some other code, r?pbz

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bdb943f8ee6
do not open window-internal modal prompts if the window is in a modal state through some other code, r=pbz

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/3bdb943f8ee6

Comment 4

[Alexandru Trif, Desktop QA [:atrif]]

Hello! Verified the issue using Firefox 90.0a1 (20210520095745) on macOS 11.3. The browser is working as expected after following the str from comment 0.
Just to be sure I have two questions:

1. When trying to exit the browser while the Primary Password modal is displayed NS_ERROR_NOT_AVAILABLE: Prompt could not be shown. error is displayed in the browser console. Is this expected?
2. Also, the Close tabs and quit window is not displayed after closing the Primary password window if triggered while it's active as stated in comment 0 expected result. This is expected as well?

Thank you in advance.

Comment 5

[:Gijs (he/him)]

(In reply to Alexandru Trif, QA [:atrif] from comment #4)

Hello! Verified the issue using Firefox 90.0a1 (20210520095745) on macOS 11.3. The browser is working as expected after following the str from comment 0.
Just to be sure I have two questions:

1. When trying to exit the browser while the Primary Password modal is displayed NS_ERROR_NOT_AVAILABLE: Prompt could not be shown. error is displayed in the browser console. Is this expected?

Yes.

2. Also, the Close tabs and quit window is not displayed after closing the Primary password window if triggered while it's active as stated in comment 0 expected result. This is expected as well?

Yes, it wasn't easily possible to fix this issue in a way where the modal would automatically reopen.

When we fix the primary password modal to use the same style of modal prompt as the quit warning (bug 1685329), both of these issues will be resolved.

(bouncing needinfo to ensure this doesn't get lost)

Comment 6

[Alexandru Trif, Desktop QA [:atrif]]

Thank you, Gijs! Marking Firefox 90.0a1 (20210520095745) as verified based on the above.

Comment 7

[Romain Testard [:RT]]

Can we please uplift to Beta 89?

Comment 8

[:Gijs (he/him)]

Comment on attachment 9222373 [details]
Bug 1711466 - do not open window-internal modal prompts if the window is in a modal state through some other code, r?pbz

Beta/Release Uplift Approval Request

• User impact if declined: Broken browser if you try to quit when the primary password prompt is up
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0 / comment 4 and later
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively minor JS-only changes, with automated test coverage.
• String changes made/needed: None

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9222373 [details]
Bug 1711466 - do not open window-internal modal prompts if the window is in a modal state through some other code, r?pbz

Approved for our last beta before 89 RC, thanks.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/d1ebd070d27d

Comment 11

[Alexandru Trif, Desktop QA [:atrif]]

Verified fixed with Firefox 89.0b15 (20210520185752) on macOS 11.3.1. The browser is no longer stuck after following the STR from comment 0. Also, the Close tabs and exit window is not displayed if triggered while the Primary Password modal is active.