[css-fonts] extend font-size-adjust to take a pair of values: <metric> <number>
Categories
(Core :: Layout: Text and Fonts, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: mozilla-apprentice, Assigned: jfkthame)
References
Details
(Keywords: dev-doc-complete)
Attachments
(5 files)
A resolution was made for csswg-drafts/#6160.
[css-fonts] extend font-size-adjust to take a pair of values: <metric> <number>
- RESOLVED: Start with ex cap ic and ch
|
Assignee | |
Comment 1•3 years ago
|
||
I have a WIP patch for this, though we'll need to get clarity on https://github.com/w3c/csswg-drafts/issues/6288 in order to finalize the implementation.
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D115211
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depends on D115211
|
|
Assignee | |
Comment 5•3 years ago
|
||
We have a couple of tests that fail on tryserver on certain platforms (though they pass for me locally),
apparently because the glyph measurements used to support the various glyph-related metrics may be
affected by resolution and/or hinting settings. So these are annotated as fuzzy for now.
If we undertake a reimplementation of font metrics to better harmonize behavior across platforms
(a longstanding wish!), perhaps we'll be able to eliminate these discrepancies.
Depends on D116280
|
|
Assignee | |
Comment 6•3 years ago
|
||
The test here used a face with src: local(Arial);, while the reference file used font-family: Arial, sans-serif;
but these may not reliably result in the same behavior. The @font-face rule looks up a specific face,
and if that face is not found, the test will fall back to the browser's default font; but the reference might
get a different result if, for example, a fontconfig alias/substitution rule is present that maps Arial to
a different sans-serif than the browser's default.
So instead of trying to use a local font lookup to provide the metrics contrast with Ahem, this patch specifically
loads a second font resource (in both the testcase and reference) to provide consistent behavior.
Depends on D116282
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a15cec1f0554 Implement CSS support for the optional adjustment-basis metric keywords for the font-size-adjust property (enabled on Nightly only for now). r=emilio https://hg.mozilla.org/integration/autoland/rev/85b6b2648f60 Support various metrics (not only ex-height) as the basis for font-size-adjust calculations in the gfx font implementations. r=layout-reviewers,emilio https://hg.mozilla.org/integration/autoland/rev/4e689776fe5d Add the extended (two-value) font-size-adjust syntax to various WPT tests. r=emilio https://hg.mozilla.org/integration/autoland/rev/3d1d2b4a2713 Remove metadata annotations for Linux-specific WPT failures that are fixed by more accurate 'ex' computation. r=emilio https://hg.mozilla.org/integration/autoland/rev/f1b19a0463cd Adjust css-values/ex-unit-001 test to avoid dependency on locally-installed font lookup. r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29253 for changes under testing/web-platform/tests
|
||
Comment 9•3 years ago
|
||
Backed out for multiple failures e.g. test_css-properties-db.js
backout: https://hg.mozilla.org/integration/autoland/rev/e944fbfe2151c8b1dcddab157dd4732ff378aac7
failure logs:
- TEST-UNEXPECTED-FAIL | devtools/shared/tests/xpcshell/test_css-properties-db.js | xpcshell return code: 0
- REFTEST TEST-UNEXPECTED-FAIL | gfx/tests/crashtests/856784-1.html | assertion count 1 is more than expected 0 assertions
- TEST-UNEXPECTED-FAIL | toolkit/content/tests/widgets/test_videocontrols.html | checking expected playback position
Upstream PR was closed without merging
|
||
Comment 11•3 years ago
|
||
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b6140578afaf Implement CSS support for the optional adjustment-basis metric keywords for the font-size-adjust property (enabled on Nightly only for now). r=emilio https://hg.mozilla.org/integration/autoland/rev/37ddac04a09b Support various metrics (not only ex-height) as the basis for font-size-adjust calculations in the gfx font implementations. r=layout-reviewers,emilio https://hg.mozilla.org/integration/autoland/rev/46b6ee998a7f Add the extended (two-value) font-size-adjust syntax to various WPT tests. r=emilio https://hg.mozilla.org/integration/autoland/rev/658694a38b47 Remove metadata annotations for Linux-specific WPT failures that are fixed by more accurate 'ex' computation. r=emilio https://hg.mozilla.org/integration/autoland/rev/43c6edbfc3da Adjust css-values/ex-unit-001 test to avoid dependency on locally-installed font lookup. r=emilio
|
|
||
Comment 12•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b6140578afaf
https://hg.mozilla.org/mozilla-central/rev/37ddac04a09b
https://hg.mozilla.org/mozilla-central/rev/46b6ee998a7f
https://hg.mozilla.org/mozilla-central/rev/658694a38b47
https://hg.mozilla.org/mozilla-central/rev/43c6edbfc3da
Upstream PR merged by moz-wptsync-bot
|
||
Comment 14•3 years ago
|
||
Updated docs, BCD, and experimental features.
|
||
Comment 15•2 years ago
|
||
[closing comment 9's backout-needinfo, since this re-landed after that.]
Description
•